feat: Add InnoDB engine to migration create table methods #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add the attribute only when using MySQL. https://github.com/codeigniter4/shield/actions/runs/4989110786/jobs/8932607159?pr=745 |
|
['ENGINE' => 'InnoDB'] has been restricted to MySQLi platform only. |
datamweb
reviewed
May 16, 2023
src/Database/Migrations/2020-12-28-223112_create_auth_tables.php
Outdated
Show resolved
Hide resolved
| $authConfig = config('Auth'); | ||
| $this->tables = $authConfig->tables; | ||
| $this->ifNotExists = false; | ||
| $this->attributes = ($this->db->getPlatform() === 'MySQLi') ? ['ENGINE' => 'InnoDB'] : []; |
There was a problem hiding this comment.
@kenjis , as far as I know, MySQLi, OCI8, Postgre and SQLSRV accept the attributes ['ENGINE' => 'InnoDB'].
And only SQLite3 does not understand ['ENGINE' => 'InnoDB']. Isn't it better to act as follows?
$this->attributes = ($this->db->getPlatform() === 'SQLite3') ? [] : ['ENGINE' => 'InnoDB'];
There was a problem hiding this comment.
No. InnoDB (and ENGINE) is configration only in MySQL.
I believe OCI8, Postgre and SQLSRV does not understand the attribute.
I don't know why these drivers do not report an error like SQLite.
There was a problem hiding this comment.
So it will stay like i did it, e.g. restricted to MySQL only!
kenjis
reviewed
May 16, 2023
src/Database/Migrations/2020-12-28-223112_create_auth_tables.php
Outdated
Show resolved
Hide resolved
kenjis
approved these changes
May 17, 2023
datamweb
approved these changes
May 17, 2023
|
@kpeu3u Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #741