Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: add copyright to all files with linter #925

Merged
merged 1 commit into from
Nov 20, 2023
Merged

style: add copyright to all files with linter #925

merged 1 commit into from
Nov 20, 2023

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Oct 22, 2023 •
edited
Loading

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb
Copy link
Collaborator Author

datamweb commented Oct 22, 2023 •
edited
Loading

@lonnieezell You are the author of Shield, should your name be added? I am not very familiar with copyright laws.

Your name is already registered in the license:
https://github.com/codeigniter4/shield/blob/92b5755008f96f219d7bc8eabbd53d2434aa50a8/LICENSE#L3C1-L4

@datamweb datamweb merged commit fce00ac into codeigniter4:develop Nov 20, 2023
33 checks passed
@datamweb
Copy link
Collaborator Author

I'm merging this, hope I didn't do something wrong.

@datamweb datamweb deleted the add-copyright-all-file branch November 20, 2023 15:53
@datamweb datamweb mentioned this pull request Nov 20, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

@lonnieezell lonnieezell Awaiting requested review from lonnieezell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@datamweb @kenjis @paulbalandan