Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HELP WANTED]: Update language strings to latest develop #148

Closed
10 of 27 tasks
paulbalandan opened this issue Nov 29, 2020 · 36 comments
Closed
10 of 27 tasks

[HELP WANTED]: Update language strings to latest develop #148

paulbalandan opened this issue Nov 29, 2020 · 36 comments
Labels
help wanted Extra attention is needed

Comments

@paulbalandan
Copy link
Member

paulbalandan commented Nov 29, 2020

With the merge of #144 , language strings for translation are kept up to date with codeigniter4/codeigniter4 repo. Originally, this was with codeigniter4/framework so the strings were updated up to the recent release v4.0.4.

We are recruiting the help from the community as well as the maintainers of the locales to update the translation sets with the language strings from the main repo. You can read on the latest Contributing guide and how to run the specific locale tests in the Test README.

Checklist of Completed Locales

  • ar | Arabic
  • cs | Czech
  • de | German
  • es | Spanish
  • fa | Farsi
  • fr | French
  • id | Indonesian
  • it | Italian
  • ja | Japanese
  • ko | Korean
  • lt | Lithuanian
  • lv | Latvian
  • ml | Malayalam
  • nl | Dutch
  • no | Norwegian
  • pl | Polish
  • pt | Portuguese
  • pt-BR | Brazilian
  • ru | Russian
  • si | Sinhala
  • sk | Slovak
  • sv-SE | Swedish - Sweden
  • tr | Turkish
  • uk | Ukrainian
  • vi | Vietnamese
  • zh-CN | Simple Chinese
  • zh-TW | Traditional Chinese

Please link your PRs here so we can keep track of the progress.

@paulbalandan paulbalandan added the help wanted Extra attention is needed label Nov 29, 2020
@paulbalandan paulbalandan pinned this issue Nov 29, 2020
@totoprayogo1916
Copy link
Contributor

Lang ID updated see PR #149

@sfadschm
Copy link
Contributor

I could take a look at de if @sba is busy. #81 should be handled beforehand maybe.

@paulbalandan
Copy link
Member Author

@sfadschm please do so. The next release is around the corner and we hope to get this done by then.

@sfadschm
Copy link
Contributor

On it. I just tried using the new test suite, but I get:
Class 'CodeIgniter\Language\AbstractTranslationTestCase' not found in D:\GitHub\translations\tests\Language\GermanTranslationTest.php:17
codeigniter4 is installed in D:\GitHub\translations\vendor\
I don't really get why it can't find the abstract case that is in the same folder. Maybe a namespace issue?
Working on Windows 10.

@paulbalandan
Copy link
Member Author

I made that class on Windows 10. Probably missed running composer update first? Or your composer.json isn't updated yet?

@sfadschm
Copy link
Contributor

Thanks, never tried composer, but this was quite easy :D

@sba
Copy link
Contributor

sba commented Nov 30, 2020

@sfadschm you updated/translated all DE-strings, right? Or does it need my help?

@sfadschm
Copy link
Contributor

sfadschm commented Nov 30, 2020

@sba yes, they are done. There was only a few left, so it didn't take too long.

@sfadschm
Copy link
Contributor

@sba I think I will look through the old messages this evening, too and see if I find any issues. If you have time, it would be nice if you could scan any changes in the PR tomorrow.

@sba
Copy link
Contributor

sba commented Nov 30, 2020

@sfadschm ok, I will check all DE-files tomorrow

@paulbalandan
Copy link
Member Author

paulbalandan commented Dec 8, 2020

To all , we have a new file to translate: Security.php. Maybe this just needs some copy paste.

@sfadschm
Copy link
Contributor

sfadschm commented Dec 8, 2020

Should these keys replace the old ones in HTTP.php or duplicate? From #3961 in the main repo, the old ones in HTTP do not seem to be removed, is this intended?

@sba
Copy link
Contributor

sba commented Dec 8, 2020

@sfadschm I translated Security.php - do you concur? (seen too late that these are also in HTTP.php - translated slightly different..

@paulbalandan
Copy link
Member Author

Should these keys replace the old ones in HTTP.php or duplicate? From #3961 in the main repo, the old ones in HTTP do not seem to be removed, is this intended?

Looking at the changes, those HTTP keys should have been removed as dupes.

@sba
Copy link
Contributor

sba commented Dec 8, 2020

Looking at the changes, those HTTP keys should have been removed as dupes.

But the keys are still present in:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/system/Language/en/HTTP.php

@paulbalandan
Copy link
Member Author

Looking at the changes, those HTTP keys should have been removed as dupes.

But the keys are still present in:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/system/Language/en/HTTP.php

Fixed in codeigniter4/CodeIgniter4#3973

@paulbalandan
Copy link
Member Author

@tangix and @Terrorboy , would need some help updating sv-SE and ko for latest changes in develop. Thanks.

@Terrorboy
Copy link
Contributor

@paulbalandan #205

@kenjis
Copy link
Member

kenjis commented Jan 17, 2021

Time.invalidFormat is added.

I made a PR: #206

@tangix
Copy link
Contributor

tangix commented Jan 20, 2021

@paulbalandan
PR: #207

@sfadschm
Copy link
Contributor

@paulbalandan How to we handle the 4.0.5 to 4.1 differences?

@paulbalandan
Copy link
Member Author

As the current workflow only looks at the main repo's develop branch, I guess we have to wait until 4.1 gets merged to develop before we can do anything.

@sfadschm
Copy link
Contributor

I was rather wondering that after 4.1 was merged to develop and we update the translation repo to 4.1, how can someone still download the translations for 4.0.5 afterwards if they want to stay with that version of the framework?
Will we do branches for translations, too?

@paulbalandan
Copy link
Member Author

Ideally the flow should be that if there is a release in the main repo, the same should be done here. So if there is framework v4.0.5 there is also translations v4.0.5.

If ever this repo gets left behind, say 4.1 gets merged there before a release was made here, then all changes for 4.1 would be directed to a new branch.

@Terrorboy
Copy link
Contributor

4.1.1 Do you proceed with translation?
Has any of the content already been translated?

@paulbalandan
Copy link
Member Author

4.1.1 Do you proceed with translation?
Has any of the content already been translated?

We cannot wait for the other locales if the maintainers are not active. We have to meet the long overdue release as promised. Besides, the translations will still work even if incomplete as we always fallback to English. If people want to have their locales updated to the latest, they need to step up and submit PRs, but that would be for the next releases.

@Terrorboy
Copy link
Contributor

The work was proceeded because it was not confirmed whether the entire translation was in progress for v4.1.1.
After checking, when the v4.1.1 application is ready, please merge.

#215

@kenjis
Copy link
Member

kenjis commented Mar 15, 2021

Add new lang item translation for ja #218

@Terrorboy
Copy link
Contributor

@paulbalandan
Can I write the Korean translation release number of readme.md as 4.1.1?
Or should I change it to 4.0.3?

@paulbalandan
Copy link
Member Author

@paulbalandan
Can I write the Korean translation release number of readme.md as 4.1.1?
Or should I change it to 4.0.3?

What do you mean?

@Terrorboy
Copy link
Contributor

Terrorboy commented Mar 18, 2021

Should I change the release number to 4.1.1 or 4.0.4 in the next update?

image
image
image

@Terrorboy Terrorboy mentioned this issue Mar 18, 2021
@paulbalandan
Copy link
Member Author

@Terrorboy the release number in the README.md corresponds to the version tag where the locale is first introduced to the repo. In this case, ko was introduced in v4.0.2 that's why is tagged as 4.0.2 so this does not need to updated.

@paulbalandan
Copy link
Member Author

Closing this as this does not receive the attention I expected for it. I have realized most of locales were made one-time-big-time and were pretty unmaintained since then. The help wanted label, therefore, is practically useless. If anyone wants to step up and update their locale of concern, you can do with a PR. Leaving this issue open is moot.

@tangix
Copy link
Contributor

tangix commented Aug 16, 2021

@paulbalandan
is there an easy way for us to get the list of newly added or changed strings to translate for each release?

@paulbalandan
Copy link
Member Author

The fastest way I can think of is running PHPUnit for the locale specifically: vendor/bin/phpunit --filter SampleTranslationTest

@pawelkg
Copy link
Contributor

pawelkg commented Nov 4, 2021

Hi! I've just send PR #250 with polish translations up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants