New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HELP WANTED]: Update language strings to latest develop #148
Comments
Lang ID updated see PR #149 |
@sfadschm please do so. The next release is around the corner and we hope to get this done by then. |
On it. I just tried using the new test suite, but I get: |
I made that class on Windows 10. Probably missed running |
Thanks, never tried composer, but this was quite easy :D |
@sfadschm you updated/translated all DE-strings, right? Or does it need my help? |
@sba yes, they are done. There was only a few left, so it didn't take too long. |
@sba I think I will look through the old messages this evening, too and see if I find any issues. If you have time, it would be nice if you could scan any changes in the PR tomorrow. |
@sfadschm ok, I will check all DE-files tomorrow |
To all , we have a new file to translate: |
Should these keys replace the old ones in |
@sfadschm I translated |
Looking at the changes, those HTTP keys should have been removed as dupes. |
But the keys are still present in: |
Fixed in codeigniter4/CodeIgniter4#3973 |
@tangix and @Terrorboy , would need some help updating |
I made a PR: #206 |
@paulbalandan |
@paulbalandan How to we handle the 4.0.5 to 4.1 differences? |
As the current workflow only looks at the main repo's |
I was rather wondering that after |
Ideally the flow should be that if there is a release in the main repo, the same should be done here. So if there is framework v4.0.5 there is also translations v4.0.5. If ever this repo gets left behind, say 4.1 gets merged there before a release was made here, then all changes for 4.1 would be directed to a new branch. |
4.1.1 Do you proceed with translation? |
We cannot wait for the other locales if the maintainers are not active. We have to meet the long overdue release as promised. Besides, the translations will still work even if incomplete as we always fallback to English. If people want to have their locales updated to the latest, they need to step up and submit PRs, but that would be for the next releases. |
The work was proceeded because it was not confirmed whether the entire translation was in progress for v4.1.1. |
Add new lang item translation for ja #218 |
@paulbalandan |
What do you mean? |
@Terrorboy the release number in the README.md corresponds to the version tag where the locale is first introduced to the repo. In this case, |
Closing this as this does not receive the attention I expected for it. I have realized most of locales were made one-time-big-time and were pretty unmaintained since then. The help wanted label, therefore, is practically useless. If anyone wants to step up and update their locale of concern, you can do with a PR. Leaving this issue open is moot. |
@paulbalandan |
The fastest way I can think of is running PHPUnit for the locale specifically: |
Hi! I've just send PR #250 with polish translations up to date. |
With the merge of #144 , language strings for translation are kept up to date with
codeigniter4/codeigniter4
repo. Originally, this was withcodeigniter4/framework
so the strings were updated up to the recent releasev4.0.4
.We are recruiting the help from the community as well as the maintainers of the locales to update the translation sets with the language strings from the main repo. You can read on the latest Contributing guide and how to run the specific locale tests in the Test README.
Checklist of Completed Locales
Please link your PRs here so we can keep track of the progress.
The text was updated successfully, but these errors were encountered: