Update app code

[kenjis]

Needs #221

• use return instead of echo
• replace $heroes with $dungeons
• add codeigniter/phpstan-codeigniter

[coveralls]

Pull Request Test Coverage Report for Build 7923616178

Details

• -4 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 88.727%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
app/Controllers/HeroController.php	0	1	0.0%
app/Controllers/DungeonController.php	0	3	0.0%

Totals
Change from base Build 7923612731:	0.0%
Covered Lines:	244
Relevant Lines:	275

---

💛 - Coveralls

[kenjis]

@paulbalandan Do you know why this error is reported?

 ------ -------------------------------------------------------------------- 
  Line   tests/database/FakerTest.php                                        
 ------ -------------------------------------------------------------------- 
  49     Call to method PHPUnit\Framework\Assert::assertInstanceOf() with    
         'App\\Entities\\Dungeon' and array<int, App\Entities\Dungeon> will  
         always evaluate to false.                                           
         💡 Because the type is coming from a PHPDoc, you can turn off this   
            check by setting treatPhpDocTypesAsCertain: false in your        
            phpstan.neon.dist.                                               
 ------ -------------------------------------------------------------------- 

https://github.com/codeigniter4projects/playground/actions/runs/6680594906/job/18153864260?pr=218

[MGatner]

Thanks! Some of this is very very old 😳

[MGatner]

Oops! I missed the pipeline failures. My guess is that somewhere the array return type of find() is taking precedence over the single-value ID lookup version. I think this is a core issue with the method, violating single-responsibility, but I don't see in the framework what would cause this so hopefully @paulbalandan knows the source in his library. In the meantime we could ignore this or change it to where(...)->first().