Update http error code on FizzBuzz endpoint

codeinuit · Aug 8, 2023 · 283f90d · 283f90d
1 parent fc0209a
commit 283f90d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cmd/api/handlers.go b/cmd/api/handlers.go
@@ -41,7 +41,7 @@ func (h handlers) fizzbuzz(c *gin.Context) {
 
 	fb, err := fizzbuzz.FizzBuzz(v.Int1, v.Int2, v.Int3, v.String1, v.String2)
 	if err != nil {
-		c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
+		c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
 		return
 	}
 

diff --git a/cmd/api/handlers_test.go b/cmd/api/handlers_test.go
@@ -101,5 +101,5 @@ func TestGetFizzBuzzWrongParameter(t *testing.T) {
 	req, _ := http.NewRequest("GET", "/fizzbuzz", &b)
 	fb.engine.ServeHTTP(w, req)
 
-	assert.Equal(t, 500, w.Code)
+	assert.Equal(t, 400, w.Code)
 }