Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A basic image manager #9

Merged
merged 11 commits into from Feb 6, 2024
Merged

Conversation

tkzt
Copy link
Collaborator

@tkzt tkzt commented Jan 14, 2024

fixes #2

@tkzt tkzt force-pushed the feature/manager branch 2 times, most recently from 60b435b to 611bc59 Compare January 14, 2024 11:31
@tkzt tkzt force-pushed the feature/manager branch 4 times, most recently from 6dc1680 to aafbf69 Compare January 14, 2024 13:33
Copy link
Member

@greyli greyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some other issues (legacy Flask-SQLAlchemy query methods, large try...except statements, EOL, lint issues, etc.), but I think it's okay to fix them later.

manager/.flaskenv Outdated Show resolved Hide resolved
manager/src/templates/manager.html Outdated Show resolved Hide resolved
manager/tests/test_manager.py Outdated Show resolved Hide resolved
@tkzt
Copy link
Collaborator Author

tkzt commented Feb 5, 2024

Improved a little bit 🙃:

  • added pre-commit linter hooks
  • killed large try...except blocks
  • CI conf and other details

@greyli
Copy link
Member

greyli commented Feb 5, 2024

LGTM. Let's merge it and improve it later.

BTW, It's better to prevent huge pull requests...

@tkzt
Copy link
Collaborator Author

tkzt commented Feb 6, 2024

LGTM. Let's merge it and improve it later.

BTW, It's better to prevent huge pull requests...

Aha, got it.

@tkzt tkzt merged commit bc26072 into codekitchen-community:main Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An Flask based image manager
2 participants