Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow symlinks when copying to /bin #10

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

ryansch
Copy link
Contributor

@ryansch ryansch commented Jun 6, 2018

On rancherOS /bin is a symlink to /usr/bin. Adding -L causes docker cp to follow that symlink. Without it, we get a not a directory error and fsevents fails to start.

@morganick
Copy link

I can confirm that this does fix the issue.

@codekitchen codekitchen merged commit 57d46af into codekitchen:master Jun 6, 2018
@codekitchen
Copy link
Owner

Darn, I was worried about some of this not working for people who aren't using the default VM but don't have a great way to test such configurations. Thanks for the fix.

The docs for docker cp say the -L flag means "Always follow symbol link in SRC_PATH", but it sounds like you're saying it follows links in DEST_PATH as well?

I'll cut a new Dinghy release this evening.

@ryansch
Copy link
Contributor Author

ryansch commented Jun 6, 2018

Yeah we tested it in situ and discovered that -L works on the DEST_PATH side too.

@ryansch
Copy link
Contributor Author

ryansch commented Jun 6, 2018

@codekitchen I have at least one more PR for you.

@codekitchen
Copy link
Owner

Sounds good, I'll hold off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants