-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on PCJ source files #4
Comments
Hmm..., generated codes from fastutil seem to be a part of LGPL. |
I've got sources generated from fastutil (maybe 2 years ago?) that all have the Apache License. Where are you seeing the LGPL license? Also the documentation at http://fastutil.di.unimi.it/ seems to still say it's all Apache License. |
https://github.com/codelibs/jhighlight/blob/master/src/main/java/com/uwyn/jhighlight/fastutil/chars/AbstractChar2ObjectFunction.java |
Which version of fastutil did you use to generate that source? My version of that same file (from 6.0.0) doesn't have the LPGL license piece. |
I downloaded http://fastutil.di.unimi.it/fastutil-6.6.5-src.tar.gz and then run "make sources". |
Hmm - seems like they've got a bug in their source code generation - the project is under APL, so you're right that the header shouldn't have this in it. If you tell me which files you need, I can send you a pull with my (slightly older) versions that don't have this issue. |
I added fastutil's files to this repository. jhighlight needs them under: |
Thank you for your pull request. Merged. |
Hi Shinsuke - I don't have a strong opinion about fastutil's package namespace. In general when "borrowing" large amounts of code I try to keep it the same as the original package, but it's OK if you want to move it into your package. |
Thank you for the reply. I'll change the package name and release jar file to Maven repository if I do not find any other problems. |
Any update on status? Questions about this over at the Tika project... |
I deployed jhighlight 1.0.2 to Maven Central repository yesterday! http://repo1.maven.org/maven2/org/codelibs/jhighlight/1.0.2/ |
Thank alot @marevol, the next Tika 1.8 version will use your Jhighlight version. You can update readme.md once this version 1.8 turns out. |
All files in the https://github.com/codelibs/jhighlight/tree/master/src/main/java/com/uwyn/jhighlight/pcj package use the LGPL license, which means jhighlight isn't actually dual CDDL/LGPL license, it's LGPL only. Which means it can't be used by something like Tika.
One possibility is fastutil (http://fastutil.di.unimi.it/), which is under APL 2.0. You'd want to cherry-pick the minimum number of source files to avoid pulling in a huge jar.
The text was updated successfully, but these errors were encountered: