Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: use concurrent.futures for multithreading #202

Open
yprez opened this issue Feb 11, 2016 · 0 comments
Open

Suggestion: use concurrent.futures for multithreading #202

yprez opened this issue Feb 11, 2016 · 0 comments

Comments

@yprez
Copy link
Collaborator

yprez commented Feb 11, 2016

Since newspaper is now Python 3 only, concurrent.futures can be used in mthreading.py instead of raw access to threads.

For example, the pool management and such (like here: https://github.com/codelucas/newspaper/blob/master/newspaper/mthreading.py#L45) already exists there, and there's no reason to re-implement features that already exist in Python (3).

Also: less code => less bugs.

Maybe fix/enable some of the mutlithreading tests on the way, I've noticed these have been disabled for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant