Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade beautifulsoup4 to 4.4.1 for python 3.5 #171

Merged
merged 1 commit into from Jan 10, 2016
Merged

upgrade beautifulsoup4 to 4.4.1 for python 3.5 #171

merged 1 commit into from Jan 10, 2016

Conversation

AlJohri
Copy link
Contributor

@AlJohri AlJohri commented Nov 26, 2015

library is now compatible with python 3.5.0!

Python 3.5.0 (default, Oct 11 2015, 06:36:54)
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.0.72)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import newspaper
>>> cnn_paper = newspaper.build('http://cnn.com')
>>> cnn_paper.size()
1251

@AlJohri AlJohri mentioned this pull request Nov 26, 2015
@AlJohri
Copy link
Contributor Author

AlJohri commented Nov 26, 2015

please note that the unit tests did not pass, not sure if those are up to date. the errors had to do with nltk

codelucas added a commit that referenced this pull request Jan 10, 2016
upgrade beautifulsoup4 to 4.4.1 for python 3.5
@codelucas codelucas merged commit fa85226 into codelucas:master Jan 10, 2016
@codelucas
Copy link
Owner

This was breaking newspaper3 for everything, merging now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants