Release 3.0.0 #106
Release 3.0.0 #106
Conversation
|
@codemanki that ✔️ looks great! I'm super glad that we have these checks in place! |
|
@pro-src can we do a code freeze on this PR? So we that anything else goes into 3.0.0? |
|
@codemanki, of course. |
Rename/move specs to test so Mocha can find them Remove Gruntfile, it was only being used to start mocha and has outdated dependencies Remove grunt related dev-deps Rename/move test files Update test dependencies, add sinon-chai Change test script from grunt to mocha Add mocha.opts
100% code coverage
| @@ -26,6 +29,22 @@ __Unfortunately, there is no support for handling a CAPTCHA, if the response con | |||
|
|
|||
| If you notice that for some reason cloudscraper stopped to work, do not hesitate and get in touch with me ( by creating an issue here, for example), so i can update it. | |||
|
|
|||
| Migration from v2 to v3 | |||
There was a problem hiding this comment.
@pro-src I hope I didn't miss any other crucial points?
There was a problem hiding this comment.
We might want to advice proper usage of error.error which can be an instanceof Error in some cases. request-promise defines error.error but I believe it is a legacy attribute. I think we should promote error.cause since we're not setting those attributes ourselves. It's request/promise-core's error library that is being used to set those attributes.
There was a problem hiding this comment.
@codemanki, The 
|
Phew. I'm done with README. @pro-src please take a look and let me know if you approve this PR and I can release it as 3.0.0 |
README.md
Outdated
| @@ -180,7 +180,7 @@ Let me know, by opening [issue](https://github.com/codemanki/cloudscraper/issues | |||
|
|
|||
| WAT | |||
| =========== | |||
| Current cloudflare implementation requires browser to respect the timeout of 5 seconds and cloudscraper mimics this behaviour. So everytime you call `cloudscraper.get/post` you should expect it to return result after minimum 6 seconds. If you want to change this behaviour, you would need to make a generic request as desceribed in above and pass `cloudflareTimeout` options with your value. But be aware that cloudflare might track this timeout and use ir against you ;) | |||
| Current cloudflare implementation requires browser to respect the timeout of 5 seconds and cloudscraper mimics this behaviour. So everytime you call `cloudscraper.get/post` you should expect it to return result after minimum 6 seconds. If you want to change this behaviour, you would need to make a generic request as desceribed in above and pass `cloudflareTimeout` options with your value. But be aware that cloudflare might track this timeout and use it against you ;) | |||
There was a problem hiding this comment.
Another one in the the TODO: chalenge should be challenge 🤣
There was a problem hiding this comment.
That is a legacy typo, been there for a long time. But thank you :)
There was a problem hiding this comment.
@codemanki I'm going to look over everything thoroughly and I'll get back to you by at least tomorrow.
|
@pro-src great :) looking forward to hearing from you. Thanks! |
There was a problem hiding this comment.
The cloudscraper.defaults convenience method isn't mentioned.
var cloudscraper = require('cloudscraper').defaults({ 'proxy': 'http://localproxy.com' });
// Override headers
var headers = { /* ... */ };
var cloudscraper = require('cloudscraper').defaults({ headers: headers });
// Access cloudscraper's default options. (It's not necessary to modify them)
// Create your own default options by using the defaults method.
console.log(cloudscraper.defaultParams);| @@ -26,6 +29,22 @@ __Unfortunately, there is no support for handling a CAPTCHA, if the response con | |||
|
|
|||
| If you notice that for some reason cloudscraper stopped to work, do not hesitate and get in touch with me ( by creating an issue here, for example), so i can update it. | |||
|
|
|||
| Migration from v2 to v3 | |||
There was a problem hiding this comment.
@codemanki, The
Add short description to errors of type CloudflareError
|
Off we go? @pro-src |
|
Indeed. |
@pro-src Let's use this PR for further discussions, also i will prepare readme and docs