Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch to contributing guidelines #347

Open
tmorrell opened this issue Jan 18, 2024 · 5 comments · May be fixed by #352
Open

Add branch to contributing guidelines #347

tmorrell opened this issue Jan 18, 2024 · 5 comments · May be fixed by #352
Labels

Comments

@tmorrell
Copy link
Contributor

What branch should be used for contributions?

In the past the 'develop' branch was used as the target for pull requests, but recently it looks like the 'master' branch has been used. Once we decide, this should be documented in the contributing guidelines.

@progval
Copy link
Member

progval commented Jan 18, 2024

Yeah I kind of started using master as the branch to land development because there isn't much point in having a branch just to serve released stuff (that's what tags are for).

We might want to keep develop for vocabulary changes, so that we can still release non-vocabulary changes (ie. mostly crosswalks) in minor releases without being stuck with stabilization of unrelated changes to the vocabulary

@bact
Copy link
Contributor

bact commented Feb 16, 2024

Will these make sense?

Vocabulary changes:

  • Add/amend/remove property
  • Amend property name
  • Amend property type
  • Amend property's parent type
  • Amend property description, in a way that will change the semantic of the property

Non-vocabulary changes is all other changes that is not included in the vocabulary changes list above, including:

  • Small amendment to property description, that will NOT change the semantic of the property
  • Crosswalk and mapping updates
  • Documentation changes (README, etc)

bact added a commit to bact/codemeta that referenced this issue Feb 16, 2024
Proposal per discussion in codemeta#347 (not finalize yet). In general:

- `develop` for vocabulary changes
- `master` for non-vocabulary changes

This will resolve codemeta#347
bact added a commit to bact/codemeta that referenced this issue Feb 16, 2024
Proposal per discussion in codemeta#347 (not finalize yet). In general:

- `develop` for vocabulary changes
- `master` for non-vocabulary changes

This will resolve codemeta#347
@bact bact linked a pull request Feb 16, 2024 that will close this issue
@bact
Copy link
Contributor

bact commented Feb 20, 2024

I have proposed PR #352 for this issue. Can be change upon the discussion here.

@moranegg
Copy link
Contributor

Thanks @bact, I have approved the review. will be merged soon.

@moranegg moranegg added the Docs label Mar 21, 2024
@bact
Copy link
Contributor

bact commented Mar 22, 2024

Thanks @moranegg, I just spot one typo in the PR. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants