Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split crosswalk.csv into crosswalks/*.csv #205

Merged
merged 6 commits into from
Nov 19, 2018

Conversation

progval
Copy link
Member

@progval progval commented Nov 12, 2018

Creates one table per platform, and add a script (scripts/aggregate.py) to generate crosswalk.csv.

I wrote scripts/aggregate.py so that its output is exactly the content of crosswalk.csv before this PR; hence the hard-coded OLD_ORDER variable.
I can remove this if you wish.

This is a proposal to solve #204. Feel free to comment on it!

@cboettig
Copy link
Member

Yay, nice work! 👏 🍾

Can you also add some information to README.md documenting this? Maybe also a CONTRIBUTING.md issue template noting this structure, to remind anyone filing a PR how to do it as a separate file?

I think this will make the process much easier. We have a few stale PRs and other issues that have been caused by all the collisions of using one master file.

Thoughs @mbjones ?

@progval
Copy link
Member Author

progval commented Nov 13, 2018

Yay, nice work!

Thanks!

Can you also add some information to README.md documenting this? Maybe also a CONTRIBUTING.md issue template noting this structure, to remind anyone filing a PR how to do it as a separate file?

Done: 65cf67b

@progval
Copy link
Member Author

progval commented Nov 13, 2018

I just had a thought: when a mapping in crosswalks/ does not provide a term matching a CodeMeta property, should the row still be present?

On the one hand, it makes it obvious in each mapping which properties are missing, but on the other hand it makes many useless lines.

@cboettig
Copy link
Member

probably best for the row to be present

but hopefully the table-join script is robust enough (e.g do you use a join on schema term as the key column?) to work either way?

@progval
Copy link
Member Author

progval commented Nov 15, 2018

but hopefully the table-join script is robust enough (e.g do you use a join on schema term as the key column?) to work either way?

No; it checks all rows are present, to avoid mistakes. I can change it to make a proper join, though.

@cboettig
Copy link
Member

cboettig commented Nov 15, 2018 via email

@cboettig cboettig merged commit 2eaa31b into codemeta:master Nov 19, 2018
@cboettig
Copy link
Member

I think this is a great step forward, so I've gone and merged this in now. Thanks @progval !

proycon pushed a commit to proycon/codemeta that referenced this pull request Jan 4, 2022
* Add scripts/split.py and scripts/aggregate.py.

* Add properties_description.csv (extracted from crosswalk.csv).

* Add one crosswalk table per platform (extracted from crosswalk.csv).

* Make scripts executable.

* Run aggregate.py on Travis to check integrity of crosswalks/*.csv files.

* Write CONTRIBUTING.md, and update README.md to refer to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants