-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split crosswalk.csv into crosswalks/*.csv #205
Conversation
b0833a6
to
ae39a3b
Compare
10c005c
to
3084a3b
Compare
Yay, nice work! 👏 🍾 Can you also add some information to README.md documenting this? Maybe also a CONTRIBUTING.md issue template noting this structure, to remind anyone filing a PR how to do it as a separate file? I think this will make the process much easier. We have a few stale PRs and other issues that have been caused by all the collisions of using one master file. Thoughs @mbjones ? |
Thanks!
Done: 65cf67b |
I just had a thought: when a mapping in On the one hand, it makes it obvious in each mapping which properties are missing, but on the other hand it makes many useless lines. |
probably best for the row to be present but hopefully the table-join script is robust enough (e.g do you use a join on schema term as the key column?) to work either way? |
No; it checks all rows are present, to avoid mistakes. I can change it to make a proper join, though. |
Hmm, maybe your way is actually better to be more strict in keeping alll
rows.
On Thu, Nov 15, 2018 at 5:28 AM Valentin Lorentz ***@***.***> wrote:
but hopefully the table-join script is robust enough (e.g do you use a
join on schema term as the key column?) to work either way?
No; it checks all rows are present, to avoid mistakes. I can change it to
make a proper join, though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#205 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANleqK-OXlK6T0zkxf0sasZLCLirGHrks5uvWv3gaJpZM4YZwyW>
.
--
---
Carl Boettiger
http://carlboettiger.info/
|
I think this is a great step forward, so I've gone and merged this in now. Thanks @progval ! |
* Add scripts/split.py and scripts/aggregate.py. * Add properties_description.csv (extracted from crosswalk.csv). * Add one crosswalk table per platform (extracted from crosswalk.csv). * Make scripts executable. * Run aggregate.py on Travis to check integrity of crosswalks/*.csv files. * Write CONTRIBUTING.md, and update README.md to refer to it.
Creates one table per platform, and add a script (scripts/aggregate.py) to generate crosswalk.csv.
I wrote
scripts/aggregate.py
so that its output is exactly the content ofcrosswalk.csv
before this PR; hence the hard-codedOLD_ORDER
variable.I can remove this if you wish.
This is a proposal to solve #204. Feel free to comment on it!