-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch funding to schema.org #274
base: develop
Are you sure you want to change the base?
Conversation
Hi, I'm just checking in to see what the status of this PR is. I noticed that the |
You have the option to include 'funder' in the 'funding' object, but it's not required. I think it makes sense to include funder under funding because they are usually directly linked. Feel free to test out the codemeta.jsonld file in this PR and leave a review with how it works. Once there is some feedback it can be merged into the develop branch for the eventual v3 release #236 |
Awesome. We will update our application in preparation for this. The funder array makes more sense anyway but we shall wait for the v3 release. In the meantime, I'll work on a PR for the update on the code meta generator. |
This PR is candidate for a discussion, it changes the spec, we should label it #discussion. Also to be tagged v3.0 release if accepted by vote. |
Ping to merge this -- switching The comments says "This should be tagged for the 3.0 release" however it seems the 3.0 release is already tagged and listed in https://github.com/codemeta/codemeta/releases However 3.0 is not listed in https://codemeta.github.io/jsonld/ and https://github.com/codemeta/codemeta/#codemeta-schema or our own codemeta (#299) so perhaps 3.0 can be considered a "quiet" summer release candidate -- perhaps we can consider 3.1 to have I'm adding the remaining terms to RO-Crate 1.2 but we've always had |
Oops, that was an oversight. I guess this will have to wait for v4.0 |
Switch funding from a CodeMeta term to the schema.org term (https://schema.org/funding), as discussed in #160. I changed the example codemeta.json file to put funder inside of funding, but this is not enforced by the schema (you can still have a top-level funder field).
This should be tagged for the 3.0 release.