New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer crosswalk #277
base: develop
Are you sure you want to change the base?
Composer crosswalk #277
Conversation
Add a crosswalk table for Packagist projects. |
Thanks, @VickyMerzOwn for the crosswalk. I retargeted the PR at the develop branch and we will review it for the next release. |
Cool. My pleasure! |
hasPart, | ||
position, | ||
description,description | ||
identifier,name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want this, names are generally not good identifiers (though I realize https://github.com/codemeta/codemeta/blob/master/crosswalks/NodeJS.csv has the same issue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I take it out then?
(I added it just because it was in the file you linked)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email,author.email | ||
affiliation, | ||
identifier, | ||
name,author.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see an author
field in https://getcomposer.org/doc/04-schema.md ; I think these should just be:
email,email
affiliation,
identifier,
name,name
as email
in an item of Composer's authors
maps to email
in an item of CodeMeta's author
.
Also, huh, I just realized name
is duplicated. (the one at line 46 for SoftwareApplication name, and this one for Person/Organization name.) Other crosswalks have the same issue, should we do something about them?
(and Composer has a specific field support.email
for the SoftwareApplication's email, which we can't really express here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no email
field in the schema. The only options I can see are those you have mentioned (authors.email
or support.email
).
I think support.email
is apt to the codemeta email
field. However the description in crosswalk.csv doesn't make this so clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crosswalks/Composer.csv
Outdated
processorRequirements, | ||
releaseNotes, | ||
softwareHelp, | ||
softwareRequirements, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it. Thank you!
This PR is candidate for a discussion, we should label it #discussion. |
No description provided.