Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer crosswalk #277

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

VickyMerzOwn
Copy link
Contributor

No description provided.

@VickyMerzOwn
Copy link
Contributor Author

Add a crosswalk table for Packagist projects.
Pretty similar to NodeJS.csv but for a few changes.

@VickyMerzOwn VickyMerzOwn changed the title Packagist crosswalk Composer crosswalk Jun 6, 2022
@mbjones mbjones changed the base branch from master to develop June 6, 2022 17:49
@mbjones mbjones added this to the v3.0 milestone Jun 6, 2022
@mbjones
Copy link
Collaborator

mbjones commented Jun 6, 2022

Thanks, @VickyMerzOwn for the crosswalk. I retargeted the PR at the develop branch and we will review it for the next release.

@VickyMerzOwn
Copy link
Contributor Author

Cool. My pleasure!

hasPart,
position,
description,description
identifier,name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want this, names are generally not good identifiers (though I realize https://github.com/codemeta/codemeta/blob/master/crosswalks/NodeJS.csv has the same issue)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I take it out then?
(I added it just because it was in the file you linked)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cboettig & @mbjones: we need your expertise here

Comment on lines +52 to +55
email,author.email
affiliation,
identifier,
name,author.name
Copy link
Member

@progval progval Jun 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an author field in https://getcomposer.org/doc/04-schema.md ; I think these should just be:


email,email
affiliation,
identifier,
name,name

as email in an item of Composer's authors maps to email in an item of CodeMeta's author.

Also, huh, I just realized name is duplicated. (the one at line 46 for SoftwareApplication name, and this one for Person/Organization name.) Other crosswalks have the same issue, should we do something about them?

(and Composer has a specific field support.email for the SoftwareApplication's email, which we can't really express here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no email field in the schema. The only options I can see are those you have mentioned (authors.email or support.email).
I think support.email is apt to the codemeta email field. However the description in crosswalk.csv doesn't make this so clear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cboettig & @mbjones: we need your expertise also here

processorRequirements,
releaseNotes,
softwareHelp,
softwareRequirements,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it. Thank you!

@moranegg
Copy link
Contributor

This PR is candidate for a discussion, we should label it #discussion.
Discussion will be open until March 15th and we will then proceed to a vote from March 15th to March 25th.

@progval progval modified the milestones: v3.0, v2.1 Feb 16, 2023
@moranegg moranegg removed this from the v2.1 milestone Apr 24, 2023
@moranegg moranegg added the discussion A discussion is still needed to analyze, resolve and implement label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crosswalk discussion A discussion is still needed to analyze, resolve and implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants