Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeMirror$1 in NPM distribution #5507

Closed
tophf opened this issue Jul 22, 2018 · 2 comments
Closed

CodeMirror$1 in NPM distribution #5507

tophf opened this issue Jul 22, 2018 · 2 comments

Comments

@tophf
Copy link
Contributor

tophf commented Jul 22, 2018

NPM distribution has CodeMirror$1 due to rollup's import-export intricacies, I suppose, but there's no $1 in the official site version at http://codemirror.net/lib/codemirror.js.

I've been always using the site version, but recently AMO reviewers insisted we switch to the versioned source in NPM so now I see lots of these $1 for my editor objects in devtools when debugging live code in the browser. It's a visual noise, which I dislike.

2da57af386

Can you fix this please?

If it's not possible by re-arranging something in the source files, would you consider a post-build text replacement?

@tophf
Copy link
Contributor Author

tophf commented Jul 22, 2018

FWIW, commenting out export default CodeMirror in /src/codemirror.js removes $1 from the rollup output, and the result is just as usable at least in my case.

@marijnh
Copy link
Member

marijnh commented Jul 23, 2018

This my be due to a different version of rollup or one of its plugins being used to build the live version. I don't consider function name properties to be a significant part of the exported file, so I don't consider this an important enough issue to investigate. But if you can figure out a way to clean it up (without breaking any backwards compatibility) a pull request would definitely be welcome.

@marijnh marijnh closed this as completed Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants