[v3] undo differs from [v2]

[peterkroon]

OS: W732

• Open up Chrome stable
• Open 2 tabs: http://codemirror.net/3/demo/visibletabs.html and http://codemirror.net/demo/visibletabs.html

[v2] - bug 1

• Place cursor on line 11 via mouse at the end
• Hold down the tab key to insert ~15 tabs
• Ctrl-Z will undo all added tabs except for 1 which will remain, I consider this to be a bug

[v2]- bug 2

• Place cursor on line 11 via mouse at the end
• Hold down the tab Ctrl-] to insert ~15 tabs
• The tabs are added before the closing bracket }
• Ctrl-Z will undo all added tabs except for 1 which will remain, I consider this to be a bug

[v3] - bug 1

• Place cursor on line 11 via mouse at the end
• Hold down the tab key to insert ~15 tabs
• Ctrl-Z will undo one tab per Ctrl-Z, It's behaviour differs from [v2]

[v3]- bug 2

• same as [v2] - bug 2

[marijnh]

Undo differing in v3 is by design -- I overhauled it to be more predictable and correct. The bugs you found were not by design. The above patch should fix them (do double-check, if you have a moment).

The behavior in v2 is indeed messy, but I'm not going to fix it anymore.

[marijnh]

(Thanks for finding all these bugs, by the way!)

[peterkroon]

The above patch should fix them (do double-check, if you have a moment).

It appears to be fixed, however:

• Go go: http://codemirror.net/3/demo/visibletabs.html
• Place cursor on line 11 at the end
• Ctrl-] a new tab is inserted but it's inserted before the closing bracket and not after it
• Feels like a bug to me

(Thanks for finding all these bugs, by the way!)

Well.....It's about that time....

[marijnh]

Ctrl-] a new tab is inserted but it's inserted before the closing bracket and not after it
Feels like a bug to me

Ctrl-] is bound to indentMore. Indentation happens at the start of the line. If you want to insert a tab, use the tab key.

[peterkroon]

Ctrl-] is bound to indentMore. Indentation happens at the start of the line. If you want to insert a tab, use the tab key.

OK