Add an option to show the dialog at the bottom of the editor #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marijnh
added a commit
that referenced
this pull request
Dec 10, 2012
marijnh
added a commit
that referenced
this pull request
Dec 10, 2012
|
See attached patch. I modified the interface because things that take a single option invariably evolve to take more, so an option object is more future-proof than a boolean parameter. Otherwise, this looks great. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a boolean argument
bottomto openDialog and openConfirm to show the dialog at the bottom of the editor rather than the top. Default behavior is to show the dialog at the top, preserving original behavior.There was a DOM structure change a few CSS changes for the dialog. I tested on Chrome, Firefox, and IE9, and as far as I could tell it behaves the same as before.