Add an option to show the dialog at the bottom of the editor #1065

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@mightyguava

Adds a boolean argument bottom to openDialog and openConfirm to show the dialog at the bottom of the editor rather than the top. Default behavior is to show the dialog at the top, preserving original behavior.

There was a DOM structure change a few CSS changes for the dialog. I tested on Chrome, Firefox, and IE9, and as far as I could tell it behaves the same as before.

@marijnh
CodeMirror member

See attached patch. I modified the interface because things that take a single option invariably evolve to take more, so an option object is more future-proof than a boolean parameter. Otherwise, this looks great. Merged.

@marijnh marijnh closed this Dec 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment