fix .changed() for bookmarks #1709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Granger <ibdknox@gmail.com>
marijnh
added a commit
that referenced
this pull request
Jul 30, 2013
|
Thanks for reporting that. See attached slightly simpler patch, which should also take care of it. |
anaran
pushed a commit
to anaran/CodeMirror
that referenced
this pull request
Feb 22, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling .changed() on a bookmark throws because bookmarks do not have from and to. This is a naive solution, but it seems like a better solution would be to have bookmarks return their position in the same way that all other textmarkers do. That would definitely be an end-user breaking change, though.