Implement binding types for var/let/const variables. #5296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. I'd keep a single chain of scopes, rather than separate ones for function and block scopes, though. You can add a property that describes the type of the scope. |
|
Okay, refactored to use a single chain of scopes. Still pretty baffled by what's going wrong with the indentation failures, though - I can see that it's now setting |
|
It works! May also want to implement |
tmcw
changed the title
marijnh
added a commit
that referenced
this pull request
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress! This doesn't pass the full test suite yet, and I'm not sure why yet. This aims to fix #5138 - it makes the register() method in the JavaScript highlighting mode aware of the type of binding it is in, and also adds block context that contains block-scoped definitions. Review + hints for how to get to the finish line much appreciated!