Make sure the cursor is scrolled into view after applying a completion

FIX: Make sure the cursor is scrolled into view after inserting completion text. See https://discuss.codemirror.net/t/how-to-scroll-the-view-after-autocomplete-is-picked/6829
codemirror · Jul 18, 2023 · 4e9fc1c · 4e9fc1c
1 parent a878319
commit 4e9fc1c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/completion.ts b/src/completion.ts
@@ -269,6 +269,7 @@ export function insertCompletionText(state: EditorState, text: string, from: num
         range: EditorSelection.cursor(range.from + fromOff + text.length)
       }
     }),
+    scrollIntoView: true,
     userEvent: "input.complete"
   }
 }

diff --git a/src/snippet.ts b/src/snippet.ts
@@ -191,7 +191,8 @@ function moveField(dir: 1 | -1): StateCommand {
     let next = active.active + dir, last = dir > 0 && !active.ranges.some(r => r.field == next + dir)
     dispatch(state.update({
       selection: fieldSelection(active.ranges, next),
-      effects: setActive.of(last ? null : new ActiveSnippet(active.ranges, next))
+      effects: setActive.of(last ? null : new ActiveSnippet(active.ranges, next)),
+      scrollIntoView: true
     }))
     return true
   }
@@ -256,7 +257,9 @@ const snippetPointerHandler = EditorView.domEventHandlers({
     if (!match || match.field == active.active) return false
     view.dispatch({
       selection: fieldSelection(active.ranges, match.field),
-      effects: setActive.of(active.ranges.some(r => r.field > match!.field) ? new ActiveSnippet(active.ranges, match.field) : null)
+      effects: setActive.of(active.ranges.some(r => r.field > match!.field)
+        ? new ActiveSnippet(active.ranges, match.field) : null),
+      scrollIntoView: true
     })
     return true
   }