Make build tool configure TS to not complain about unused locals

Also, prevent watch from stopping when a build errors
codemirror · Oct 11, 2019 · f7cde72 · f7cde72
1 parent bd217a4
commit f7cde72
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/bin/cm.js b/bin/cm.js
@@ -74,13 +74,19 @@ class Pkg {
   }
 }
 
+const baseCompilerOptions = {
+  noImplicitReturns: false,
+  noUnusedLocals: false,
+  sourceMap: true
+}
+
 function tsPlugin(options) {
   return require("rollup-plugin-typescript2")({
     clean: true,
     tsconfig: path.join(root, "tsconfig.base.json"),
     tsconfigOverride: {
       references: [],
-      compilerOptions: options,
+      compilerOptions: {...baseCompilerOptions, ...options},
       include: []
     }
   })
@@ -261,7 +267,7 @@ class Watcher {
   startWork() {
     if (this.working) return
     this.working = true
-    this.run().then(() => this.working = false, e => console.log(e.stack || String(e)))
+    this.run().catch(e => console.log(e.stack || String(e))).then(() => this.working = false)
   }
 
   async run() {

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -4,7 +4,6 @@
     "types": [],
     "noImplicitReturns": true,
     "noUnusedLocals": true,
-    "sourceMap": true,
     "strict": true,
     "target": "es6",
     "newLine": "lf",