Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linux] Middle-clicking in a demo page insert $ sign in the Chrome browser. #2384

Closed
RaymondLim opened this issue Mar 17, 2014 · 7 comments
Closed

[Linux] Middle-clicking in a demo page insert $ sign in the Chrome browser. #2384

RaymondLim opened this issue Mar 17, 2014 · 7 comments

Comments

@RaymondLim
Copy link

  1. Open a demo page in the Chrome browser.
  2. Click on the middle mouse button inside the demo page.

Result: a $ sign is inserted into the page.
@RaymondLim RaymondLim mentioned this issue Mar 17, 2014
Closed
@marijnh
Copy link
Member

marijnh commented Mar 17, 2014

It inserts the last thing I selected, when I do this (Chrome 34)

@RaymondLim
Copy link
Author

My Chrome version is 29 when I reproduced it. I'm upgrading my Linux OS and Chrome now. Will let you know what I see after upgrading.

@RaymondLim
Copy link
Author

I've tried with both Chrome 33 and 34. I only get the $ sign as I click on the middle button while mouse cursor is inside the CodeMirror input field.

@marijnh
Copy link
Member

marijnh commented Mar 18, 2014

This is almost certainly a result of the fakedLastChar hack which works around https://bugs.webkit.org/show_bug.cgi?id=90206 . That bug report never got any response, but the problem seems to be solved in recent Chrome and Safari versions, so I think I'll just rip out the hack.

marijnh added a commit that referenced this issue Mar 18, 2014
@marijnh
Remove fakedLastChar hack
ef1b02e 
Issue #1474 was the cause of this hack
Issue #2384 was apparently caused by it

Recent Webkit-ish browsers seem to no longer have the problem that
it was working around.
marijnh added a commit that referenced this issue Mar 18, 2014
@marijnh
Remove fakedLastChar hack
475b2be 
Issue #1474 was the cause of this hack
Issue #2384 was apparently caused by it

Recent Webkit-ish browsers seem to no longer have the problem that
it was working around.
@marijnh
Copy link
Member

marijnh commented Mar 18, 2014

Please see if attached patch solves the problem.

@RaymondLim
Copy link
Author

Confirmed that the patch indeed fixes the issue. Thanks.

@marijnh marijnh closed this as completed Mar 18, 2014
This was referenced Apr 9, 2014
Closed
Closed
marijnh added a commit that referenced this issue Apr 9, 2014
@marijnh
Revert "Remove fakedLastChar hack"
8a6778b 
This reverts commit 475b2be.

Issue #2452
Issue #2384
@marijnh
Copy link
Member

marijnh commented Apr 9, 2014

It seems the bug that that hack address has not been solved after all. The problem reported here is less severe than said bug, so I reverted the patch that ripped out the hack.

I still haven't been able to reproduce this bug.

@marijnh marijnh reopened this Apr 9, 2014
@mtaran-google mtaran-google mentioned this issue Jun 4, 2014
Closed
@henriqueqc henriqueqc mentioned this issue Aug 12, 2014
Closed
@ErisDS ErisDS mentioned this issue Sep 11, 2014
Closed
This was referenced Aug 30, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marijnh @RaymondLim