gfm mode underscore in link url starts emphasis

[shark404]

Reproducible here: http://codemirror.net/mode/gfm/index.html

While using the gfm mode if there is an underscore in the url get parameters this triggers the start of an emphasis block. So if you have an inline link with an underscore the text following is emphasised.

Here is a link, https://test.com?_test and this text is in italics

I would expect the underscore within the link to be ignored for formatting.

I took a look at the code but seems like it may be a non-trivial fix as the underscore logic is in the markdown mode where as this "autolink" logic is in the gfm mode. Is it as simple as setting state.linkHref in the gfm link logic? https://github.com/codemirror/CodeMirror/blob/master/mode/gfm/gfm.js#L106

Is the state shared between modes? Sorry this is the first time at looking at how CodeMirror works so I don't have a clear understanding yet.

[marijnh]

@0b10011 Do you want to take a look?

[0b10011]

Yeah, I should be able to get to this in the next 24-48 hours.

[0b10011]

Sorry about the delay! I've looked into this and added a PR that fixes the issue. Had to adjust the overlay.js code to make it possible for gfm to communicate effectively with markdown (to freeze markdown's state while parsing links).