Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows/Chrome: Japanese IME suggestion list obscures inputted text #4089

Closed
MickMonaghan opened this issue Jun 27, 2016 · 8 comments
Closed
Labels

Comments

@MickMonaghan
Copy link

MickMonaghan commented Jun 27, 2016

Env
Windows 10
Chrome v51
Japanese MS IME
CodeMirror: v5.13.2 (also exists in v5.16 - and earlier versions)

To reproduce:

  • Open a code mirror mirror input area
  • activate the Japanese IME
  • type "nippon"
  • suggestion list appears

Expected Result:

  • list does not obscure the text that has been entered

Actual Result:

  • text is significantly obscured.
    cm-jaime-obscurestext
@marijnh marijnh added the IME label Jun 27, 2016
@marijnh
Copy link
Member

marijnh commented Jul 12, 2016

I booted windows 7 and enabled Microsoft Japanese IME, and it's allowing me to type Japanese characters, but never pops up a suggestion list (neither in CodeMirror nor anywhere else). Is there something else I need to enable to get that behavior?

@marijnh
Copy link
Member

marijnh commented Jul 12, 2016

Oh, it was pressing space that triggered the menu. Unfortunately, on my system, both in Linux and Windows 7, the resulting widget is perfectly aligned with the bottom of the cursor. This might be related to your CSS -- could you see if it happens on the demo pages on http://codemirror.net on your system? If not, it would be helpful if you could set up a minimal demo page with your CSS in it that allows me to reproduce the issue.

@marijnh
Copy link
Member

marijnh commented Jul 12, 2016

On closer look at the screenshot, that is the project page, so I'll see if I can install windows 10 to see if it reproduces there.

@marijnh
Copy link
Member

marijnh commented Jul 12, 2016

Okay, on Windows 10 with Chrome 51 I could reproduce this. Attached patch works around the issue.

@marijnh
Copy link
Member

marijnh commented Jul 12, 2016

Um, I mean patch 51a1e7d, which I attached to the wrong issue.

@MickMonaghan
Copy link
Author

Excellent @marijnh - thank you. Looks good to me also.

@adrianheine
Copy link
Contributor

Apparently this is fixed, great!

@tamo
Copy link

tamo commented Oct 9, 2022

It seems that something is wrong with Firefox.
image

let te = elt("textarea", null, null, "position: absolute; bottom: -1em; padding: 0; width: 1px; height: 1em; min-height: 1em; outline: none")
let div = elt("div", [te], null, "overflow: hidden; position: relative; width: 3px; height: 0px;")

The wrapping div should have height, shouldn't it?

This code

 let te = elt("textarea", null, null, "position: absolute; top: 0; bottom: 1em; padding: 0; width: 1px; height: 1em; min-height: 1em; outline: none") 
 let div = elt("div", [te], null, "overflow: hidden; position: relative; width: 3px; height: 1em; margin-bottom: -1em;") 

would produce something better, like this:
image

(1em should be replaced with 1.5em (==line-height) also?)

I'm not familiar with CSS. You all must know better. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants