Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong highlighting and indentation for Python f-strings with nested strings #5668

Closed
aldanor opened this issue Nov 15, 2018 · 2 comments
Closed

Wrong highlighting and indentation for Python f-strings with nested strings #5668

aldanor opened this issue Nov 15, 2018 · 2 comments

Comments

@aldanor
Copy link

aldanor commented Nov 15, 2018

Example:

a = g(f'{b["c"]}') # oops

The comment will be highlighted wrong (as if it was still a part of the string), and if you hit enter the subsequent indentation will be wrong:

image
@marijnh
Copy link
Member

marijnh commented Nov 16, 2018

Attached patch should help with this

@aldanor
Copy link
Author

aldanor commented Nov 16, 2018

Thanks! That was very fast :)

@atsukoba atsukoba mentioned this issue May 7, 2019
Closed
cone56 pushed a commit to cone56/CodeMirror that referenced this issue Jan 6, 2020
@marijnh @cone56
[python mode] Fix tokenizing of nested strings
a85bc47 
Closes codemirror#5668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marijnh @aldanor