Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

div.CodeMirror-selected for bespin #7018

Closed
stdedos opened this issue Feb 1, 2023 · 1 comment
Closed

div.CodeMirror-selected for bespin #7018

stdedos opened this issue Feb 1, 2023 · 1 comment

Comments

@stdedos
Copy link

stdedos commented Feb 1, 2023

Hello there,

I'd like to propose a change for the div.CodeMirror-selected selector for bespin

Line:

.cm-s-bespin div.CodeMirror-selected {background: #36312e !important;}

should become:

background: #595959 !important;

or equivalent.

My proposal is an educated guess by looking around the repo, "what looks best", "sticking close to the theme colors", and by the intuition that "there won't be any setting that would get AA(A) a11y score"

Discussion here: openstyles/stylus#1538

@marijnh marijnh closed this as completed in 58f5925 Feb 2, 2023
@marijnh
Copy link
Member

marijnh commented Feb 2, 2023

Attached patch increases the contrast on this.

mrdrogdrog pushed a commit to hedgedoc/CodeMirror that referenced this issue Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants