Vim mode word selection is off by one (affecting diw/daw/diW/daW)

[abrooks]

There are several variants of the bug, but, most basically, if you have this text and are sitting on "A":

foo bAr baz

And you execute diw, you'll get:

foo r baz

Instead of:

foo baz

This issue affects all of the following delete motions: diw, daw, diW, daW as well as their change (ciw...), yank (yiw...) and visual (viw...) variations.

I created 28 tests covering various edge cases (26 cases fail without the patch) and all now pass. lint was happy as well.

Let me know if there's anything you'd like me to change — style, completeness or otherwise.

Thanks!

[mightyguava]

I'd been hoping someone would take a serious crack at fixing text objects. This is one of the best patches I've seen so far. Great job and thanks for the unit tests!

The patch mostly looks good, except that I think you need to also consider words separated by multiple spaces? Your patch seems to only take into account single spaces.

[abrooks]

I'd be happy to. Give me a few minutes or so and I'll push again.

[abrooks]

@mightyguava Good call. Vim deletes all whitespace trailing or preceding for the "a" inclusive motions. This will take longer as I adjust the code. I'll update the pull request with the new changes when they're done.

[abrooks]

This updated push addresses both the multi-whitespace tests and the fixed logic to handle the multi-whitespace inclusion. Really, the logic reads more like the Vim behavior now anyways.

Let me know if there are more tests or other changes to the commits you'd like to see.

[mightyguava]

Looks good to me. Thank you for taking the time to make these changes. I really appreciate your attention to detail. Lots of people will be happy to see these fixes :)

[abrooks]

Thanks! I really appreciate the project and hope to contribute again. :)

[marijnh]

Thanks! Merged.

[lynschinzer]

Thanks +1, this patch is seriously awesome!