[lint plugins] Allow lint plugins to output HTML formatted messages #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijel
added a commit
to phpmyadmin/phpmyadmin
that referenced
this pull request
Jul 18, 2017
- add patch to CodeMirror to render HTML, it's submitted upstream as codemirror/codemirror5#4861 - properly escape html output of Linter, now when we use full HTML Fixes #13489 Signed-off-by: Michal Čihař <michal@cihar.com>
|
Looks good. Could you use |
This is opt-in, the plugin needs to produce message_html instead of message to be rendered as HTML.
|
Good point, changed to |
nijel
added a commit
to phpmyadmin/phpmyadmin
that referenced
this pull request
Jul 18, 2017
See codemirror/codemirror5#4861 Signed-off-by: Michal Čihař <michal@cihar.com>
|
Thank you. Merged! |
|
Thanks, that was fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is opt-in, the plugin needs to produce message_html instead of
message to be rendered as HTML.
We were using this with custom patch at phpMyAdmin, but I think it's better to integrate such feature upstream.