Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append the tooltip to the wrapper element #6135

Closed
wants to merge 2 commits into from
Closed

Append the tooltip to the wrapper element #6135

wants to merge 2 commits into from

Commits on Feb 4, 2020

  1. Append the tooltip to the wrapper element 

    The tooltip in the existing way append to the body.
When applied the codemirror context inside a shadow root (custom element) this calls append the tooltip out of the root components.
Thus, the user has to monkey patch the appendchild method to override the behavior.

This change would allow the tooltip to render in its own context.
    @tejasrivastav
    tejasrivastav committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    d268bea View commit details
    Browse the repository at this point in the history

  2. fix: render tooltip inside the editor optionally

    @tejasrivastav
    tejasrivastav committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    9d39a60 View commit details
    Browse the repository at this point in the history