Support generics syntax in JSX with TS #7073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does this assume there will be a trailing comma in the type parameter list? Is that a thing people use to work around this ambiguity in TSX code? |
|
@marijnh yes, it tells the typescript compiler to recognize that it's a type, not a JSX tag. |
marijnh
pushed a commit
that referenced
this pull request
Oct 27, 2023
marijnh
added a commit
that referenced
this pull request
Oct 27, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a function that uses generics will look like this when the mode is JSX with TypeScript.
With this fix, it will now be highlighted correctly: