Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py] Fixed parsing of relative from-imports #312

Merged
merged 1 commit into from Sep 2, 2020
Merged

[py] Fixed parsing of relative from-imports #312

merged 1 commit into from Sep 2, 2020

Conversation

superbobry
Copy link
Contributor

No description provided.

@superbobry
Copy link
Contributor Author

I'm not quite sure why the previous grammar didn't work, so if you have any insights, that'd be really helpful.

@marijnh marijnh merged commit 3b87d7b into codemirror:master Sep 2, 2020
@marijnh
Copy link
Member

marijnh commented Sep 2, 2020

I guess it would parse import as an expression in that context, but it looks like you realized that, given the !import lookahead you added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@superbobry @marijnh