Added release notes, made defaultValue optional

README.md

@@ -22,6 +22,15 @@ The design philosophy is; make command line argument parsing simple so you can s
 ## Usage
 
 Include it as a dependency.
+
+```
+<dependency>
+    <groupId>com.github.codemonstur</groupId>
+    <artifactId>jcli</artifactId>
+    <version>1.0.0</version>
+</dependency>
+```
+
 Use the builder to parse a class you decorated with the proper annotations.
 
 ```

pom.xml

@@ -3,7 +3,7 @@
 
     <groupId>com.github.codemonstur</groupId>
     <artifactId>jcli</artifactId>
-    <version>1.0.0</version>
+    <version>1.1.0</version>
 
     <name>${project.groupId}:${project.artifactId}</name>
     <description>A command line parser</description>

src/docs/releases/release-1.1.0.txt

@@ -0,0 +1,4 @@
+1.1.0
+
+Updated license
+Made the defaultValue configuration optional. null will be set instead

src/main/java/jcli/CliHelp.java

@@ -15,7 +15,6 @@
 import static jcli.Reflection.*;
 import static jcli.Util.isNullOrEmpty;
 import static jcli.Util.padRight;
-import static jcli.annotations.Constants.FAKE_NULL;
 
 public enum CliHelp {;
 
@@ -26,8 +25,11 @@ public static void printHelp(final String name, final Class<?> clazz) {
         System.out.println(getHelp(name, clazz));
     }
 
-    public static String getHelp(final String builderName, final Class<?> clazz) throws InvalidOptionConfiguration {
-        return getHelp(builderName, "   ", clazz);
+    public static String getHelp(final Class<?> clazz) throws InvalidOptionConfiguration {
+        return getHelp(null, clazz);
+    }
+    public static String getHelp(final String name, final Class<?> clazz) throws InvalidOptionConfiguration {
+        return getHelp(name, "   ", clazz);
     }
 
     public static String getHelp(final String builderName, final String indent, final Class<?> clazz) throws InvalidOptionConfiguration {
@@ -50,8 +52,8 @@ public static String getHelp(final String builderName, final String indent, fina
                 throw new InvalidOptionType(option);
             if (option.name() == ' ' && option.longName().isEmpty())
                 throw new InvalidOptionName(field.getName());
-            if (hasMissingDefault(option, field))
-                throw new MissingDefaultForOption(option);
+//            if (hasMissingDefault(option, field))
+//                throw new MissingDefaultForOption(option);
 
             final String optionName = toName(option);
             final String optionNeed = option.isMandatory() ? "mandatory" : "optional";
@@ -103,11 +105,11 @@ private static String processCliCommandAnnotation(final StringBuilder builder, f
 
     private static void printUsage(final StringBuilder builder, final String name, final Class<?> clazz) {
         builder.append("Usage: ")
-                .append(name)
-                .append(" [options] ")
-                .append(join(" ", toPositionalNames(clazz)))
-                .append("\n\n")
-                .append("Options:\n");
+            .append(name)
+            .append(" [options] ")
+            .append(join(" ", toPositionalNames(clazz)))
+            .append("\n\n")
+            .append("Options:\n");
     }
 
     private static boolean hasExamples(String[] examples) {
@@ -133,4 +135,5 @@ private static String toName(final CliOption option) {
         if (!option.longName().isEmpty()) builder.add("--"+option.longName());
         return join(" ", builder);
     }
+
 }

src/main/java/jcli/CliParser.java

@@ -81,7 +81,7 @@ private static Map<String, FieldAndOption> toFieldAndOptionMap(final Class clazz
                 throw new HelpTypeNotBoolean(field);
 
             // TODO test if this is really desired, maybe better to just leave the field alone with whatever was defined in the class
-            if (hasMissingDefault(option, field)) throw new MissingDefaultForOption(option);
+            // if (hasMissingDefault(option, field)) throw new MissingDefaultForOption(option);
 
             addFieldAndOption(map, field, option);
         }
@@ -142,8 +142,7 @@ private static <T> T applyArgumentsToInstance(final String[] args, final Map<Str
             if (isListType(fao.field)) continue;
             if (fao.option.isMandatory()) throw new MissingArgument(fao.option);
 
-            // TODO this might be the better option
-            // if (fao.argument.defaultValue().equals(FAKE_NULL)) continue;
+            if (fao.option.defaultValue().equals(FAKE_NULL)) continue;
 
             fao.field.set(instance, toFieldType(fao.field.getType(), fao.option.defaultValue()));
         }

src/main/java/jcli/Reflection.java

@@ -1,6 +1,5 @@
 package jcli;
 
-import jcli.annotations.CliOption;
 import jcli.annotations.CliUnderscoreIsDash;
 import jcli.errors.InvalidArgumentValue;
 
@@ -17,8 +16,6 @@
 import java.util.*;
 import java.util.regex.Pattern;
 
-import static jcli.annotations.Constants.FAKE_NULL;
-
 public enum Reflection {;
 
     public interface StringToType<T> {
@@ -146,9 +143,9 @@ public static Class<?> toParameterType(final Field field) {
         return (Class<?>) ((ParameterizedType)field.getGenericType()).getActualTypeArguments()[0];
     }
 
-    public static boolean hasMissingDefault(final CliOption option, final Field field) {
-        if (field.getType().equals(List.class)) return false;
-        return !option.isMandatory() && !isBooleanType(field) && !option.isHelp() && option.defaultValue().equals(FAKE_NULL);
-    }
+//    public static boolean hasMissingDefault(final CliOption option, final Field field) {
+//        if (field.getType().equals(List.class)) return false;
+//        return !option.isMandatory() && !isBooleanType(field) && !option.isHelp() && option.defaultValue().equals(FAKE_NULL);
+//    }
 
 }

src/test/java/unittests/TestInvalidOptions.java

@@ -54,11 +54,11 @@ public void optionWithoutName() throws InvalidCommandLine {
         fail("Parser failed to throw exception InvalidOptionName");
     }
 
-    @Test(expected = MissingDefaultForOption.class)
-    public void optionMissingDefault() throws InvalidCommandLine {
-        final String[] args = {};
-        parseCommandLineArguments(args, MissingDefault::new);
-
-        fail("Parser failed to throw exception MissingDefaultForOption");
-    }
+//    @Test(expected = MissingDefaultForOption.class)
+//    public void optionMissingDefault() throws InvalidCommandLine {
+//        final String[] args = {};
+//        parseCommandLineArguments(args, MissingDefault::new);
+//
+//        fail("Parser failed to throw exception MissingDefaultForOption");
+//    }
 }