Pixel-perfect styling of Popup Dialogs #3233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the solution for https://stackoverflow.com/questions/63449222/problems-in-the-styling-of-a-popupdialog
It adds the method
setUIIDByPopupPosition
to use the UIIDs "PopupContentPaneDownwards", "PopupContentPaneUpwards", "PopupContentPaneRight", "PopupContentPaneLeft".If this method is not explicitly invoked, the working of the code remains the same as before, ensuring backward compatibility.
Example of usage:
Example of CSS to get (almost) identical styling on iOS and Android, assuming that in the previous code I call
d.setUIIDByPopupPosition(true)
only on Android devices (this is not a requirement, it's my choice):Final note: the use of custom UIIDs for 'PopupContentPane' is safe, while the use of custom UIIDs for
PopupDialog
is not safe because it can break the UI (I experienced that, that's why my method sets custom UIIDs for 'PopupContentPane' only).