boolean test

codenautas · Nov 8, 2016 · 4c81918 · 4c81918
1 parent 26902d0
commit 4c81918
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/discrepances.js b/lib/discrepances.js
@@ -42,7 +42,8 @@ function getClassOnlyForSomeOfBuiltIns(variable) {
     if(variable instanceof RegExp) { return 'RegExp'; }
     if(variable instanceof Array) { return 'Array'; }
     if(variable instanceof Object) { return 'Object'; }
-    throw new Error('undetected class type');
+    // console.log("SS", JSON.stringify(variable));
+    throw new Error('undetected class type:' + typeof variable);
 }
 
 function timeStr(dt) { return datetime(dt).toYmdHmsM().substr(11); }
@@ -166,6 +167,7 @@ var defaultOpts = {
 discrepances = function discrepances(a, b, opts){
     opts = changing(defaultOpts, opts||{});
     if(a === b){ return null; }
+    // console.log("D", a, b, opts)
     /*eslint-disable eqeqeq */
     if(opts.autoTypeCast && a == b){ return null; }
     /*eslint-enable eqeqeq */
@@ -174,6 +176,7 @@ discrepances = function discrepances(a, b, opts){
     if(typeA === typeB) {
         if(typeA === 'number') { return {difference:a-b, values:[a,b]}; }
         if(typeA === 'string') { return compareStrings(a, b); }
+        if(typeA === 'boolean') { return {values:[a, b]}; }
         if(typeA==='object' && typeB==='object') {
             var classA = getClassOnlyForSomeOfBuiltIns(a);
             var classB = getClassOnlyForSomeOfBuiltIns(b);

diff --git a/test/test.js b/test/test.js
@@ -124,7 +124,7 @@ describe("discrepances", function(){
         {a:76                              , b:"76"              , expect:discrepances(76, "76"),                            },
         {skip:true, a:{a:7}                , b:no                , expect:null                  , opts:{duckTyping:true}     },
         {skip:true, a:{a:7}                , b:no                , expect:{classes:['Object', '#null__proto__']}             },
-        {skip:true, a:false                , b:true              , expect:{values:[false, true]}                             },
+        {a:false                           , b:true              , expect:{values:[false, true]}                             },
     ];
     // esto es para evitar que values:[] tenga fechas distintas a 'a' y 'b'
     var dateFixtures = [