qa-control

codenautas · Nov 1, 2016 · 7c50349 · 7c50349
1 parent 6e28b81
commit 7c50349
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.eslintrc.yml b/.eslintrc.yml
@@ -44,7 +44,7 @@ rules:
   # Best Practices
   accessor-pairs: 2
   block-scoped-var: 0
-  complexity: [2, 13]
+  complexity: [2, 14]
   consistent-return: 0
   curly: 0
   default-case: 0

diff --git a/lib/discrepances.js b/lib/discrepances.js
@@ -157,19 +157,19 @@ function isSimpleValue(classType) {
 }
 
 discrepances = function discrepances(a, b, opts){
-    var opts = changing({unordered:true}, opts||{});
+    opts = changing({unordered:true}, opts||{});
     if(a === b){ return null; }
     var typeA = getType(a);
     var typeB = getType(b);
     if(typeA === typeB) {
         if(typeA === 'number') { return {difference:a-b, values:[a,b]}; }
         if(typeA === 'string') { return compareStrings(a, b); }
         if(typeA==='object' && typeB==='object') {
+            var classA = getClassOnlyForSomeOfBuiltIns(a);
+            var classB = getClassOnlyForSomeOfBuiltIns(b);
             if(a.constructor !== b.constructor) {
                 return {classes:[constructorName(a),constructorName(b)]};
             }
-            var classA = getClassOnlyForSomeOfBuiltIns(a);
-            var classB = getClassOnlyForSomeOfBuiltIns(b);
             if(classA !== classB) {
                 var r = {classes:[classA,classB]};
                 if(isSimpleValue(classA) && isSimpleValue(classB)) { r.values=[a,b]; }