Valida los nombres de los atributos.

codenautas · Jan 6, 2016 · 58354f4 · 58354f4
1 parent 8396248
commit 58354f4
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/js-to-html.js b/js-to-html.js
@@ -106,7 +106,24 @@ var validDirectProperties={
                         }
                     }
                     return true;
-                }}
+                }},
+                {check:function(attributes, o){  
+                    /*jshint forin:false */
+                    for(var attrName in attributes){
+                        /*jshint forin:true */
+                        var htmlName = (jsToHtml.htmlAttrs[attrName]||{}).synonym||attrName;
+                        var attrInfo=jsToHtml.htmlAttributes[htmlName];
+                        if(/-/.test(htmlName)){
+                        }else if(!attrInfo){
+                            throw new Error("inexistent attribute");
+                        }else{
+                            if(!attrInfo[o.tagName] && !attrInfo["HTML elements"]){
+                                throw new Error("attribute does not match with tagName");
+                            }
+                        }
+                    }
+                    return true;
+                }},
             ]},
             content:{checks:[
                 {check:function(x){ return typeof x==="object" && x instanceof Array; }, text:"must be an Array"},
@@ -313,7 +330,7 @@ jsToHtml.direct=function direct(directObject){
 jsToHtml.indirect=function indirect(tagName,contentOrAttributes,contentIfThereAreAttributes){
     var thereAreAttributes=isPlainObject(contentOrAttributes);
     if(!thereAreAttributes && contentOrAttributes instanceof Object && !(contentOrAttributes instanceof Array)){
-        throw new Error('jsToHmlt.'+tagName+' expects plain object of attributes or array of content');
+        throw new Error('jsToHtml.'+tagName+' expects plain object of attributes or array of content');
     }
     var attributes = thereAreAttributes?contentOrAttributes:{};
     var content    = thereAreAttributes?contentIfThereAreAttributes:contentOrAttributes;

diff --git a/test/test.js b/test/test.js
@@ -160,8 +160,8 @@ describe('js-to-html', function(){
         });
         it('should delimite with simple quotes attribute value if contains some not alphabetic chars', function(){
             expect(
-                html.p({"class":'names', title:'this title', empty:''},'text').toHtmlText()
-            ).to.eql("<p class=names title='this title' empty=''>text</p>");
+                html.p({"class":'names', title:'this title', lang:''},'text').toHtmlText()
+            ).to.eql("<p class=names title='this title' lang=''>text</p>");
         });
         it('should escape text', function(){
             expect(direct({textNode:'esto < esto & > aquello \'sí\' y "no"'}).toHtmlText()).to.eql(
@@ -267,7 +267,7 @@ describe('js-to-html', function(){
         });
         it('should reject content for void elements', function(){
             expect(function(){
-                direct({tagName:'link', attributes:{src: "http://correct.com"}, content:["content"]})
+                direct({tagName:'link', attributes:{href: "http://correct.com"}, content:["content"]})
             }).to.throwError(/void elements must not have content/);
         });
     });