Skip to content

Commit

Permalink
Agrego stringizeStats() para #23
Browse files Browse the repository at this point in the history
  • Loading branch information
diegoefe committed Nov 7, 2016
1 parent 4d2c532 commit d3e0a54
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 13 deletions.
2 changes: 1 addition & 1 deletion bin/fast.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ function doFast(params, inputBase, fastBufferingThreshold, outputStream) {
fastFinalize(info, outStream);
}
rl.preparedResult = preparedResult;
rl.stats = txtToSql.generateStats(info).stats;
rl.stats = txtToSql.finalizeStats(info).stats;
outStream.end();
});
return streamToPromise(rl);
Expand Down
3 changes: 1 addition & 2 deletions bin/txt-to-sql-run.js
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,7 @@ Promises.start(function() {
return writeConfigYaml(createParams(params, result.preparedResult), inputBase+'.yaml');
}).then(function() {
process.stdout.write("Generated '"+inputBase+".sql'");
// WARN: implicit string conversion of result.stats!
process.stdout.write("\n"+result.stats);
process.stdout.write("\n"+txtToSql.stringizeStats(result.stats));
});
} else if (cmdParams.prepare) {
return doPrepare(params, inputYaml);
Expand Down
12 changes: 8 additions & 4 deletions lib/txt-to-sql.js
Original file line number Diff line number Diff line change
Expand Up @@ -662,11 +662,14 @@ function initializeStats(info) {
return info;
}

function generateStats(info) {
info.stats = JSON.stringify(info.stats);
function finalizeStats(info) {
return info;
}

function stringizeStats(stats) {
return JSON.stringify(stats);
}

function generateScripts(info){
return Promise.resolve(info)
.then(initializeStats)
Expand All @@ -677,7 +680,7 @@ function generateScripts(info){
.then(removeIgnoredLines)
.then(generateInsertScript)
.then(processOutputBuffer)
.then(generateStats)
.then(finalizeStats)
.catch(catchErrors.bind(null, info));
}

Expand Down Expand Up @@ -714,7 +717,8 @@ txtToSql.createInsertInto = createInsertInto;
txtToSql.createInsertValues = createInsertValues;
txtToSql.generatePrepareResult = generatePrepareResult;
txtToSql.initializeStats = initializeStats;
txtToSql.generateStats = generateStats;
txtToSql.finalizeStats = finalizeStats;
txtToSql.stringizeStats = stringizeStats;

txtToSql.engines = engines;

Expand Down
5 changes: 4 additions & 1 deletion src/txt-to-sql.jade
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ html(lang=lang)
cn:'NotaciónCientífica'
},
step3:'Paso 3: ',
step4:'Estadísticas: ',
download:'descargar',
},
en:{
Expand Down Expand Up @@ -127,6 +128,7 @@ html(lang=lang)
cn:'CientificNotation'
},
step3:'Step 3: ',
step4:'Statistics: ',
download:'download',
}
}[window.lang||'es'];
Expand Down Expand Up @@ -255,13 +257,13 @@ html(lang=lang)
elems.push(html.span(' warning(s): '+generated.warnings.join(', ')).create())
}
addStep(messages.step3, elems);
addStep(messages.step4, stringizeStats(generated.stats));
}).catch(function(err){
errMessage.textContent=err.message;
});
}
function handlePrepare(event){
var files = getID('inputFile').files;
//var files = event.target.files; // FileList object
resetPage();
Array.prototype.forEach.call(files, function(file){
console.log('file: '+file.name)
Expand Down Expand Up @@ -324,6 +326,7 @@ html(lang=lang)
butGenerate
]).create()]);
errMessage.textContent=""; // if all goes ok, clear' em
delete getID('inputFile').files;
}).catch(function(err){
errMessage.textContent=err.message+"\n"+err.stack;
});
Expand Down
5 changes: 4 additions & 1 deletion web/txt-to-sql.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
cn:'NotaciónCientífica'
},
step3:'Paso 3: ',
step4:'Estadísticas: ',
download:'descargar',
},
en:{
Expand Down Expand Up @@ -72,6 +73,7 @@
cn:'CientificNotation'
},
step3:'Step 3: ',
step4:'Statistics: ',
download:'download',
}
}[window.lang||'es'];
Expand Down Expand Up @@ -200,13 +202,13 @@
elems.push(html.span(' warning(s): '+generated.warnings.join(', ')).create())
}
addStep(messages.step3, elems);
addStep(messages.step4, stringizeStats(generated.stats));
}).catch(function(err){
errMessage.textContent=err.message;
});
}
function handlePrepare(event){
var files = getID('inputFile').files;
//var files = event.target.files; // FileList object
resetPage();
Array.prototype.forEach.call(files, function(file){
console.log('file: '+file.name)
Expand Down Expand Up @@ -269,6 +271,7 @@
butGenerate
]).create()]);
errMessage.textContent=""; // if all goes ok, clear' em
delete getID('inputFile').files;
}).catch(function(err){
errMessage.textContent=err.message+"\n"+err.stack;
});
Expand Down
12 changes: 8 additions & 4 deletions web/txt-to-sql.js
Original file line number Diff line number Diff line change
Expand Up @@ -662,11 +662,14 @@ function initializeStats(info) {
return info;
}

function generateStats(info) {
info.stats = JSON.stringify(info.stats);
function finalizeStats(info) {
return info;
}

function stringizeStats(stats) {
return JSON.stringify(stats);
}

function generateScripts(info){
return Promise.resolve(info)
.then(initializeStats)
Expand All @@ -677,7 +680,7 @@ function generateScripts(info){
.then(removeIgnoredLines)
.then(generateInsertScript)
.then(processOutputBuffer)
.then(generateStats)
.then(finalizeStats)
.catch(catchErrors.bind(null, info));
}

Expand Down Expand Up @@ -714,7 +717,8 @@ txtToSql.createInsertInto = createInsertInto;
txtToSql.createInsertValues = createInsertValues;
txtToSql.generatePrepareResult = generatePrepareResult;
txtToSql.initializeStats = initializeStats;
txtToSql.generateStats = generateStats;
txtToSql.finalizeStats = finalizeStats;
txtToSql.stringizeStats = stringizeStats;

txtToSql.engines = engines;

Expand Down

0 comments on commit d3e0a54

Please sign in to comment.