Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete hosted zone and its records correctly #86

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@itkq
Copy link
Contributor

itkq commented Dec 27, 2019

When I tried to delete hosted zone, I got the following error.

$ roadwork -a --dry-run --target '^foo.bar$' --force
Apply `Routefile` to Route53 (dry-run)
Delete Hostedzone: foo.bar. (dry-run)
[ERROR] NoMethodError: undefined method `delete' for #<Aws::Route53::Types::ResourceRecordSet:0x00007ff81a9a3278>

ResourceRecordSetWrapper#delete was removed in a3876f6#diff-f8d164d49d5178a7c052045f1e269148.

So I changed to submit a batch request to delete records associated with
the target hosted zone as well.

@sorah Could you review?

When I tried to delete hosted zone, I got the following error.

```
$ roadwork -a --dry-run --target '^foo.bar$' --force
Apply `Routefile` to Route53 (dry-run)
Delete Hostedzone: foo.bar. (dry-run)
[ERROR] NoMethodError: undefined method `delete' for #<Aws::Route53::Types::ResourceRecordSet:0x00007ff81a9a3278>
```

ResourceRecordSetWrapper#delete was removed in a3876f6#diff-f8d164d49d5178a7c052045f1e269148.

So I changed to submit a batch request to delete records associated with
the target hosted zone as well.
@sorah
sorah approved these changes Jan 8, 2020
@itkq itkq merged commit 0a54b70 into codenize-tools:master Jan 8, 2020
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@itkq itkq deleted the itkq:delete-hosted-zone-correctly branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.