Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LOG.error with LOG.debug #1358

Closed
skryzhny opened this issue Dec 15, 2016 · 2 comments
Closed

Replace LOG.error with LOG.debug #1358

skryzhny opened this issue Dec 15, 2016 · 2 comments

Comments

@skryzhny
Copy link
Contributor

Got this error:

2016-12-15 08:10:40,965[ted-scheduler-8]  [ERROR] [c.a.s.WorkspaceActivityManager 124]  - Failed to stop the workspace
org.eclipse.che.api.core.ConflictException: Could not stop the workspace '11111:11111' because its status is 'SNAPSHOTTING'.
        at org.eclipse.che.api.workspace.server.WorkspaceManager.checkWorkspaceIsRunning(WorkspaceManager.java:820) ~[che-core-api-workspace-5.0.0-M8.jar:5.0.0-M8]
        at org.eclipse.che.api.workspace.server.WorkspaceManager.stopWorkspace(WorkspaceManager.java:488) ~[che-core-api-workspace-5.0.0-M8.jar:5.0.0-M8]
        at org.eclipse.che.api.workspace.server.WorkspaceManager.stopWorkspace(WorkspaceManager.java:464) ~[che-core-api-workspace-5.0.0-M8.jar:5.0.0-M8]
        at com.codenvy.activity.server.WorkspaceActivityManager.invalidate(WorkspaceActivityManager.java:120) ~[codenvy-hosted-workspace-activity-5.0.0-M8.jar:5.0.0-M8]
        at sun.reflect.GeneratedMethodAccessor294.invoke(Unknown Source) ~[na:na]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_45]
        at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_45]
        at org.eclipse.che.commons.schedule.executor.LoggedRunnable.run(LoggedRunnable.java:53) [che-core-commons-schedule-5.0.0-M8.jar:5.0.0-M8]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_45]
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [na:1.8.0_45]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) [na:1.8.0_45]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) [na:1.8.0_45]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_45]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_45]
        at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45]

We need to check status before attempting to stop it.
Probably we need to check it on API level additionally to checks in dashboard and IDE.

For 2 days I had 5 exceptions:
# grep -c "because its status is 'SNAPSHOTTING'." catalina.out 5
Also please consider changing loglevel to WARNING and don't print stacktrace.

Reproduction Steps:

Don't know

Expected behavior:

No errors, check state of container before issuing command.

Observed behavior:

Errors in log.

Codenvy version: 5.0.0-M8
OS and version: Centos 7.2

Additional information:

Problem only started happening recently, didn't happen in an older version of Codenvy: No
Problem can be reliably reproduced: Yes

@gazarenkov
Copy link

Agree, it is not a ERROR but I doubt we need a WARNING about it, just DEBUG, it looks like a normal situation so it depends on client logic how to process it.
It should just reasonable react - like notify user that snapshotting is in progress, so he(she) should wait for some time (I believe client can be notified when it is done)

@skabashnyuk skabashnyuk added this to the 5.1.0 milestone Dec 21, 2016
@skabashnyuk skabashnyuk changed the title Error: Failed to stop the workspace **** because its status is 'SNAPSHOTTING'. Replace LOG.error with LOG warn Dec 21, 2016
@skabashnyuk skabashnyuk changed the title Replace LOG.error with LOG warn Replace LOG.error with LOG.debug Dec 21, 2016
@bmicklea bmicklea modified the milestones: 5.0.0, 5.1.0 Jan 10, 2017
@bmicklea
Copy link
Contributor

Closing as PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants