Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcegraph factory examples from getting-started page works wrong #430

Closed
musienko-maxim opened this issue Jul 21, 2016 · 7 comments
Closed

Comments

@musienko-maxim
Copy link
Contributor

musienko-maxim commented Jul 21, 2016

Reproduction Steps:

  1. Go to the https://www.eclipse.org/che/getting-started/cloud/
  2. Consuming Sourcegraph factory

Expected behavior: The project should be cloned and run.
Observed behavior: We have just empty folder with unknown project

Che version: 4.5.0
OS and version: Ubuntu OS 14.0
Chrome browser
Server location https://beta.codenvy.com
Additional information:

@TylerJewell
Copy link
Contributor

please provide specific details.

@musienko-maxim musienko-maxim changed the title Php and Sourcegraph factory examples from getting-started page work wrong PHP and Sourcegraph factory examples from getting-started page work wrong Jul 21, 2016
@benoitf
Copy link
Contributor

benoitf commented Jul 21, 2016

on sourcegraph when cloning the repository on my computer I have

$ git clone https://sourcegraph.com/sourcegraph/sourcegraph
Cloning into 'sourcegraph'...
remote: Counting objects: 148092, done.
remote: Compressing objects: 100% (60876/60876), done.
receiving objects:  12% (17772/148092), 2.75 MiB | 792.00 KiB/s

but if I try : import project
image

seems like a git/importer regression

@musienko-maxim musienko-maxim changed the title PHP and Sourcegraph factory examples from getting-started page work wrong Sourcegraph factory examples from getting-started page work wrong Jul 21, 2016
@musienko-maxim musienko-maxim changed the title Sourcegraph factory examples from getting-started page work wrong Sourcegraph factory examples from getting-started page works wrong Jul 21, 2016
@slemeur
Copy link
Contributor

slemeur commented Jul 22, 2016

Add "severity/blocker" not because the factory is not working, but because of the git/importer regression.

@riuvshin
Copy link

riuvshin commented Jul 22, 2016

Can we have factory configuration or url to the project to be able to reproduce it on test environment?

@TylerJewell TylerJewell added this to the 4.6.0 milestone Jul 23, 2016
@mshaposhnik
Copy link
Contributor

Found the root of the problem: sourcegraph has client filtering by user-agent, so clients other than native git (we're using JGit now) receive 404 status. Example:
Not working:
curl -v "https://sourcegraph.com/sourcegraph/sourcegraph/info/refs?service=git-upload-pack
Working:
curl -v -H "User-Agent: git/2.1.0" "https://sourcegraph.com/sourcegraph/sourcegraph/info/refs?service=git-upload-pack"

So we have 2 options here:

  1. Start endless discussion with sourcegraph to allow other clients too;
  2. Just improve JGit client to always masquerade as native git client;

@slemeur @skabashnyuk @TylerJewell what do you prefer ?

@mshaposhnik
Copy link
Contributor

Fixed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants