Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to provide additional workspace mount #565

Closed
ghost opened this issue Aug 12, 2016 · 7 comments
Closed

Make it possible to provide additional workspace mount #565

ghost opened this issue Aug 12, 2016 · 7 comments

Comments

@ghost
Copy link

ghost commented Aug 12, 2016

Some customer use cases imply mounting host directories in workspace container. Currently it is impossible both on user and admin level.

It should be possible for an installation admin to provide host paths to be mounted in workspace containers that start on a machine node.

@ghost ghost added the kind/enhancement label Aug 12, 2016
@ghost
Copy link
Author

ghost commented Aug 12, 2016

@bmicklea please comment on urgency and motivation for this issue.

@MuhamadSherif
Copy link

Hi @eivantsov , yes I have the same issue since my product needs to mount to a NAS server, and after some search I found it's impossible to do that directly from the container and I need to mount the host to the NAS server first then to mount container to host.
but unfortunately I cannot do that using codenvy.

@TylerJewell
Copy link
Contributor

@eivantsov - I am starting to see variations of this come up from different customers. You said specifically that an admin would need to identify the host paths. Maybe it would be better to have two modes:
1: Admin defined, where admin must define list of all host paths available, or:
2: User defined, where the user can provide any set of host paths they would like.

How would a user who is authoring a workspace recipe know about, and be able to use these mounts? Would they just magically work inside the workspace, or would we display something to the user, perhaps at the top of their terminal when it opens? Something like, "# Workspace has added host mounts for x, y, and z"

@ghost
Copy link
Author

ghost commented Aug 16, 2016

@TylerJewell as Codenvy On Prem admin I will not let any user mount any path - that's for sure. It's a huge risk of bringing the entire system down. A user can mount some critical Unix paths and mess up with files.

It should be admin who defines mount paths and mode (read only?).

Just my 2 cents.

@TylerJewell
Copy link
Contributor

Yes, absolutely agree -it would be an admin selection only, and it would come with a lot of risk factors.

@ghost
Copy link
Author

ghost commented Aug 26, 2016

@tolusha is taking care of it in this issue - #499

@bmicklea
Copy link
Contributor

Closing this as a duplicate of #499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants