Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate AMD FSR1 (v0.6.6) #33

Merged
merged 9 commits into from Oct 4, 2022
Merged

Integrate AMD FSR1 (v0.6.6) #33

merged 9 commits into from Oct 4, 2022

Conversation

codeonwort
Copy link
Owner

This PR integrates AMD FSR1 (v1.0.2).

  1. Add cvar r.super_res.method to toggle FSR1.
  2. Add cvar r.fsr1.quality to control FSR1 quality mode. (0~3: ultra quality, quality, balanced, performance)
  3. Add cvar r.fsr1.sharpness to control FSR1 sharpness. (0.0~2.0, default is 0.2)

NOTE: Always use FP32 fallback for now. I used GTX 1660 Super for this work but it does not support GLSL FP16 extension. I'll test FP16 when my RTX 3080 Ti is available. Also, need to check Ryzen 6800U.

@codeonwort codeonwort added the feature Add new feature label Oct 3, 2022
@codeonwort codeonwort self-assigned this Oct 3, 2022
@codeonwort
Copy link
Owner Author

FP16 version is neither available on Ryzen 6800U. Following two extensions are required, but not supported:

  • GL_EXT_shader_16bit_storage
  • GL_EXT_shader_explicit_arithmetic_types

Do merge in current state as my RTX 3080 Ti is not available now. Check it later.

@codeonwort codeonwort merged commit 3fff463 into master Oct 4, 2022
@codeonwort codeonwort deleted the fsr1 branch October 4, 2022 03:11
@codeonwort codeonwort added this to Done in Pathos Oct 4, 2022
@codeonwort
Copy link
Owner Author

These GLSL extensions are also unavailable in RTX 3080 Ti.

  • GL_EXT_shader_16bit_storage
  • GL_EXT_shader_explicit_arithmetic_types

In OpenGL, it seems I have to use GL_NV_gpu_shader5 instead of GL_EXT_shader_16bit_storage, and define explicit conversion functions as there is no alternative to GL_EXT_shader_explicit_arithmetic_types.

@codeonwort
Copy link
Owner Author

FP16 mode is available by 79fe014, anyway the GPU cost is not that different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add new feature
Projects
Pathos
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant