Remove the sgemm_nt_1_sycl PoC #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-goli
approved these changes
Apr 4, 2024
aacostadiaz
commented
Apr 4, 2024
Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>
AD2605
reviewed
Apr 4, 2024
AD2605
approved these changes
Apr 4, 2024
mehdi-goli
added a commit
that referenced
this pull request
Apr 4, 2024
* Remove sgemm_nt_1 PoC * Fix build issues * Fix code style format * Remove ENABLE_NVPTX flag * Update include/cute/util/debug.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Cosmetic --------- Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>
mehdi-goli
added a commit
that referenced
this pull request
Apr 4, 2024
* Updating README-sycl.md to capture the 3.5 modifications * Update README-sycl.md Co-authored-by: aacostadiaz <alejandro.acosta@codeplay.com> * Remove the sgemm_nt_1_sycl PoC (#15) * Remove sgemm_nt_1 PoC * Fix build issues * Fix code style format * Remove ENABLE_NVPTX flag * Update include/cute/util/debug.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Cosmetic --------- Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Applying the comments --------- Co-authored-by: aacostadiaz <alejandro.acosta@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the sgemm_nt_1_sycl PoC implemented before the new examples for Cute were added in Cutlass 3.5.
It also fixes some build issues introduced in PR#13 and addresses some issues with code style.