forked from NVIDIA/cutlass
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Epilogue Pipeline for PVC using EVT #80
Open
muhammad-tanvir-1211
wants to merge
19
commits into
codeplaysoftware:sycl-develop
Choose a base branch
from
muhammad-tanvir-1211:intel-epilogue
base: sycl-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Epilogue Pipeline for PVC using EVT #80
muhammad-tanvir-1211
wants to merge
19
commits into
codeplaysoftware:sycl-develop
from
muhammad-tanvir-1211:intel-epilogue
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-goli
reviewed
May 31, 2024
mehdi-goli
reviewed
May 31, 2024
mehdi-goli
reviewed
May 31, 2024
mehdi-goli
reviewed
May 31, 2024
mehdi-goli
reviewed
May 31, 2024
mehdi-goli
reviewed
May 31, 2024
aacostadiaz
reviewed
Jun 3, 2024
aacostadiaz
reviewed
Jun 3, 2024
aacostadiaz
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
23ddf3c
to
3755c7c
Compare
* Next need to integrate EVT
* Alpha scaling working, need to fix copy atom for C
* Need to remove register spill * Need to reduce error margin
3755c7c
to
8d1f87b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the Epilogue implementation for PVC using the Epilogue Visitor Tree available for SM90 (and onwards) GPUs for NVIDIA. We only support
fusion::LinearCombination
operation for PVC i.e.D = alpha * A * B + beta * C
through this PR, but it can be extended further to add otherfusion
operations by partial specialization of theFusionCallBacks
struct available in theinclude/cutlass/epilogue/fusion/intel_pvc_callbacks.hpp
file.