Run AlignModuleStructsPass earlier. #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
approved these changes
May 22, 2024
The AlignModuleStructsPass patches up structs according to OpenCL alignment requirements so that they behave the same way on all implementations. We were already calling this, but we were calling it after running a number of upstream LLVM passes, so we were feeding them incorrect input and hoping we could correct that afterwards. A change has gone in on LLVM 19 that performs a valid optimization that we cannot correct afterwards, so make sure we run AlignModuleStructsPass as soon as we know what target we are compiling for.
hvdijk
force-pushed
the
align-module-structs-early
branch
from
04274d0
to
9f6d9f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Run AlignModuleStructsPass earlier.
Reason for change
The AlignModuleStructsPass patches up structs according to OpenCL alignment requirements so that they behave the same way on all implementations. We were already calling this, but we were calling it after running a number of upstream LLVM passes, so we were feeding them incorrect input and hoping we could correct that afterwards. A change has gone in on LLVM 19 that performs a valid optimization that we cannot correct afterwards.
Description of change
Make sure we run AlignModuleStructsPass as soon as we know what target we are compiling for.
Anything else we should know?
If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.
Checklist