Fix native builtins with double or half as the input. #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
changed the title
uwedolinsky
reviewed
May 23, 2024
source/cl/test/UnitCL/kernels/regression.109_libm_native_double_input.cl
Show resolved
Hide resolved
source/cl/test/UnitCL/kernels/regression.109_libm_native_double_input.cl
Show resolved
Hide resolved
source/cl/test/UnitCL/kernels/regression.110_libm_native_half_input.cl
Outdated
Show resolved
Hide resolved
source/cl/test/UnitCL/kernels/regression.110_libm_native_half_input.cl
Outdated
Show resolved
Hide resolved
coldav
force-pushed
the
colin/fix_native_double_builtins
branch
from
86fb0fd
to
50daa52
Compare
hvdijk
reviewed
May 27, 2024
source/cl/test/UnitCL/kernels/regression.109_libm_native_double_input.cl
Outdated
Show resolved
Hide resolved
hvdijk
reviewed
May 27, 2024
source/cl/test/UnitCL/kernels/regression.110_libm_native_half_input.cl
Outdated
Show resolved
Hide resolved
hvdijk
reviewed
May 27, 2024
source/cl/test/UnitCL/kernels/regression.110_libm_native_half_input.cl
Outdated
Show resolved
Hide resolved
coldav
force-pushed
the
colin/fix_native_double_builtins
branch
from
50daa52
to
ed07663
Compare
If double was used as the input for the native builtins then we would get a link error. native builtins don't have an overload for double but we were providing one. This was also true of some half native builtins. Removing from the overloads fixes the issue as double or half are then cast to float.
coldav
force-pushed
the
colin/fix_native_double_builtins
branch
from
ed07663
to
eaa7b13
Compare
hvdijk
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removed half and double versions of the native functions.
Reason for change
If double was used as the input for the native builtins then we would get a link error. native builtins don't have an overload for double but we were providing one. This was also true of some half native builtins.
Description of change
Updated builtins.h to have the correct versions of the native functions.
Added UnitCL test for half and double.