Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit multi_ptr in vec store #343

Merged
merged 1 commit into from Oct 19, 2022
Merged

Use explicit multi_ptr in vec store #343

merged 1 commit into from Oct 19, 2022

Conversation

hjabird
Copy link
Collaborator

@hjabird hjabird commented Oct 19, 2022

This PR fixes #341.

  • SYCL-BLAS breaks with SYCL-2020 because the vec store function no longer implicity converts a raw pointer to a multi_ptr.
  • This is due to a new decoration template parameter in SYCL-2020.

This PR:

  • Converts raw pointers to multi_ptr for use with vec.store
  • Is compatible with SYCL-1.2.1
  • Is compatible with SYCL-2020 implementations that set the default multi_ptr decoration parameter value to "legacy".
    • This is not defined in the spec, but a common implementation detail since it helps SYCL-1.2.1 backwards compatibility.
  • Tested with DPC++ nightly 2022/10/17 (SYCL-2020 multi_ptr, does not compile before this change), and DPC++ nightly 2022/06/25 (SYCL-1.2.1 style multi_ptr).

@hjabird
Use explicit multi_ptr in vec store
4f96481 
* SYCL-BLAS breaks with SYCL-2020 because the vec store function no longer
implicity converts a raw pointer to a multi_ptr.
* This is due to a new decoration template parameter in SYCL-2020.
* This PR:
  * Converts raw pointers to multi_ptr for use with vec.store
  * Is compatible with SYCL-1.2.1
  * Is compatible with SYCL-2020 implementations that set the default
  multi_ptr decoration parameter value to "legacy".
    * This is not defined in the spec, but a common implementation detail
    since it helps SYCL-1.2.1 backwards compatibility.
* Tested with DPC++ nightly 2022/10/17 (SYCL-2020 multi_ptr, does not
compile before this change), and DPC++ nightly 2022/06/25 (SYCL-1.2.1
style multi_ptr).
@mehdi-goli mehdi-goli merged commit dfa0579 into codeplaysoftware:master Oct 19, 2022
@hjabird hjabird mentioned this pull request Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehdi-goli mehdi-goli mehdi-goli approved these changes

@Rbiessy Rbiessy Rbiessy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DPC++][SYCL-2020] SYCL-2020 vec breaks SYCL-BLAS
3 participants
@hjabird @mehdi-goli @Rbiessy