Update compiler to support icpx and latest nightly #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-Nick
force-pushed
the
update_compiler_support
branch
from
b7a428c
to
5452873
Compare
Rbiessy
reviewed
Apr 12, 2024
s-Nick
force-pushed
the
update_compiler_support
branch
2 times, most recently
from
95aa529
to
e8450fb
Compare
Rbiessy
reviewed
Apr 17, 2024
s-Nick
force-pushed
the
update_compiler_support
branch
from
e8450fb
to
9367097
Compare
Rbiessy
approved these changes
Apr 17, 2024
For consistency, adding the same math related flag to all test if the library is compiled with IntelLLVM compiler.
SYCL2020 introduced a new API for shuffle operation and the old one seems deprecated in latest intel/llvm open source compiler commit. This patch update that call to the new one to keep compiler compatibility.
Inverting device check before adding extra compiler flags to increase compatibility. Removing useless flags in test.
Removing -fno-fast-math from rotmg and rotg tests compilation causes them to fail.
Adding message for header only llibrary usage. Adding `-fno-fast-math` flag to all tests if compiler is "IntelLLVM"
s-Nick
force-pushed
the
update_compiler_support
branch
from
9367097
to
72609af
Compare
Suggest use of icpx instead of clang from intel/llvm.
Currently some configurations are not included while installing the header only version of portBLAS. This way users have to set them inside their cmake. With this patch all configuration, inclusion and definition set during local portBLAS configuration and installation are carried over and available to users from their cmake by meanings of *INTERFACE_INCLUDE_DIRECTORIES*, *INTERFACE_COMPILE_OPTIONS* and *INTERFACE_COMPILE_DEFINITIONS* variables. Signed-off-by: nscipione <nicolo.scipione@codeplay.com>
INSTALL_HEADER_ONLY and normal compilation configuration need a different value for it.
Rbiessy
reviewed
Apr 23, 2024
pgorlani
reviewed
Apr 29, 2024
pgorlani
reviewed
Apr 29, 2024
pgorlani
approved these changes
May 1, 2024
Rbiessy
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch address compilation issues with
icpxfor AMD and NVIDIA target.It add 3 flags if and only if the project is compiled using
icpxorclang++from any oneAPI release and the target is not and Intel device. The flags added forceicpxto behave as the open source intel/llvm compiler, making the project works correctly.This patch also update shuffle operation API to be compatible with the latest intel/llvm commit to allow the project to be compiled also with it.