Enable trsm test on NVIDIA GPUs when using DEFAULT TUNING_TARGET #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using DEFAULT as TUNING_TARGET highlighted a missing flag for nvidia compilation using icpx compiler. Adding flag to linker and enable back trsm tests. Signed-off-by: nscipione <nicolo.scipione@codeplay.com>
Rbiessy
approved these changes
May 24, 2024
hjabird
reviewed
May 24, 2024
hjabird
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error in
trsmthat led to disable its tests. Adding special icpx flag-mllvm=loopopt=0to the linker solves the issue. A minor change was necessary to compilegemmwith mixed precision for defaultTUNING_TARGET.